-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ZRS disks in virtualdisk and manageddisk modules #855
Conversation
@andreadecorte Please update the test case as follows, pipeline deploys the test region to be EATUS and does not support "StandardSSD_ZRS" and" Premium_ZRS"! I only changed what I wanted to update!Thank you very much!
|
thanks for the review @Fred-sun , updated managed_disk test as per suggestion |
@andreadecorte Because some locations do not support the *_ZRS account type, please update the content of "azure_test_minimal_manageddisk.yml" as follows. Thank you very much!
|
thanks @Fred-sun , updated the test as per suggestion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to change location and vm_size for service reasons
tests/integration/targets/azure_rm_virtualmachine/tasks/azure_test_minimal_manageddisk.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/azure_rm_virtualmachine/tasks/azure_test_minimal_manageddisk.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/azure_rm_virtualmachine/tasks/azure_test_minimal_manageddisk.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/azure_rm_virtualmachine/tasks/azure_test_minimal_manageddisk.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
@andreadecorte LGTM, thanks |
SUMMARY
Fixes #792
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Added 2 tests. Note that ZRS are currently only supported in selected regions, so this test right now will fail in US East. I tested it successfully in West Europe