Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update storage account to allow configuration of public network access #875

Merged
merged 18 commits into from
Jun 23, 2022
Merged

Update storage account to allow configuration of public network access #875

merged 18 commits into from
Jun 23, 2022

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented Jun 8, 2022

SUMMARY

This PR adds support for configuring public_network_access on a storage account.

Fixes #780.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/azure_rm_storageaccount.py
plugins/modules/azure_rm_storageaccount_info.py

ADDITIONAL INFORMATION

This PR also adds documentation for other parameters and return values which are existing in the storage module but were not documented.

Sanity and integration tests were run as follows:

ansible-test sanity azure_rm_storageaccount --color --junit -v
ansible-test sanity azure_rm_storageaccount_info --color --junit -v
ansible-test integration azure_rm_storageaccount --allow-destructive -v

@l3ender
remove unused storage imports
0d2fddd
@l3ender
correct test lints
dc672b2
@l3ender
update azure-storage dependency
1791c89
@l3ender
Merge remote-tracking branch 'upstream/dev' into storage-account-updates
7e946bb
@l3ender
fix storage blob test lint issues
9b5560b
@l3ender
Merge remote-tracking branch 'upstream/dev' into storage-account-updates
8d678eb
@l3ender
clean up storage test
e5c5664
@l3ender
correct blob issues
a26afb0
@l3ender
correct file upload with new APIs
af6a642
@l3ender
initial work for adding public network access
854cdda
@l3ender
update storageblob for ansible-test
4348348
@l3ender
Merge branch 'storage-account-updates' into storage-enhancements
c2b8246
@l3ender
Merge remote-tracking branch 'upstream/dev' into storage-account-updates
d7e47b2
@l3ender
Merge branch 'storage-account-updates' into storage-enhancements
0fb0fb8
@l3ender
add doc for storageaccount return params
b90aa32
@l3ender
add test coverage for new storage param
db2d22f
@l3ender
Merge branch 'dev' into storage-public-network-access
e5e0beb
@l3ender
Copy link
Contributor Author

l3ender commented Jun 8, 2022

@Fred-sun - can you please review? This is a small PR to add a single parameter to the storage account module. Thank you!

@l3ender l3ender mentioned this pull request Jun 8, 2022
Closed
@Fred-sun Fred-sun added new_feature New feature requirments work in In trying to solve, or in working with contributors ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jun 9, 2022
@xuzhang3
Copy link
Collaborator

@l3ender LGTM

@xuzhang3 xuzhang3 merged commit 7949946 into ansible-collections:dev Jun 23, 2022
@xuzhang3 xuzhang3 deleted the storage-public-network-access branch June 23, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xuzhang3 xuzhang3

Labels
new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add public_network_access to the Storage Account module
3 participants
@l3ender @xuzhang3 @Fred-sun