Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nxos_acls] Fix parsing of aces with range #816

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

KB-perByte
Copy link
Collaborator

@KB-perByte KB-perByte commented Feb 13, 2024

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

facts/acls.py

ADDITIONAL INFORMATION

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90a5352) 85.01% compared to head (17e5eac) 85.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
+ Coverage   85.01%   85.03%   +0.02%     
==========================================
  Files         211      211              
  Lines       18230    18232       +2     
==========================================
+ Hits        15498    15504       +6     
+ Misses       2732     2728       -4     

see 2 files with indirect coverage changes

@NilashishC NilashishC added the bug This issue/PR relates to a bug. label Feb 13, 2024
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7aad8223f4a44e73a74df5998ed9c4db

✔️ ansible-galaxy-importer SUCCESS in 4m 48s
✔️ build-ansible-collection SUCCESS in 9m 46s
✔️ ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 30m 17s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 37s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 35m 27s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 28m 35s (non-voting)
ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 FAILURE in 35m 32s (non-voting)
ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 FAILURE in 34m 46s (non-voting)
ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 FAILURE in 35m 46s (non-voting)
ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 FAILURE in 33m 31s (non-voting)
ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 FAILURE in 37m 17s (non-voting)
ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 FAILURE in 34m 36s (non-voting)
ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 FAILURE in 37m 26s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 32m 13s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 48s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/bf348cc2b162449080e0a5c4bdb1132c

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 10m 32s
✔️ ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 29m 47s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 05s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 36m 07s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 27m 20s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 34m 15s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 33m 50s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 39m 55s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 26s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 33m 52s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 34m 17s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 43m 36s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 32m 03s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 35s

@NilashishC NilashishC merged commit 1e5f253 into ansible-collections:main Feb 14, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nxos_acls - Parsing error when gathering ACL
2 participants