Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_ssm connection plugin should garbage collect the s3 bucket after the file transfers #222

Closed
abeluck opened this issue Sep 4, 2020 · 1 comment · Fixed by #237
Closed

aws_ssm connection plugin should garbage collect the s3 bucket after the file transfers #222

abeluck opened this issue Sep 4, 2020 · 1 comment · Fixed by #237
Assignees
@jillr
Labels
affects_2.10 bug This issue/PR relates to a bug has_pr needs_triage python3

Comments

@abeluck
Copy link

abeluck commented Sep 4, 2020

SUMMARY

The aws_ssm connection plugin uses an s3 buckets to transfer files to instances. These files remain in the bucket after the play has complete, they are never removed.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

aws_ssm connection plugin

ANSIBLE VERSION

ansible 2.10.1rc2
config file = /etc/ansible/ansible.cfg
configured module search path = ['/home/user/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /home/user/.local/lib/python3.7/site-packages/ansible
executable location = /home/user/.local/bin/ansible
python version = 3.7.3 (default, Jul 25 2020, 13:03:44) [GCC 8.3.0]

CONFIGURATION

n/a

OS / ENVIRONMENT

debian 10

STEPS TO REPRODUCE
  1. use the aws_ssm plugin
  2. look at the s3 bucket it used
  3. observe that the files are transferred are still there
EXPECTED RESULTS

The plugin should garbage collect files after transferring them.

ACTUAL RESULTS

Files written remain there forever.
abeluck added a commit to abeluck/community.aws that referenced this issue Sep 6, 2020
@abeluck
aws_ssm connection plugin: cleanup s3 bucket after file transfer (fixes
1f7c887 
ansible-collections#222)

* delete temporary files added to the transfer bucket after the transfer

The aws_ssm connection plugin uses an s3 buckets to transfer files to
instances. These files are now removed after a successful or failed
transfer to avoid littering the bucket and costing the aws account
money.
@jillr jillr self-assigned this Sep 9, 2020
@jillr
Copy link
Collaborator

jillr commented Sep 9, 2020

Hi @abeluck, thanks for reporting this (and 221). It looks like you might already be working on a pull request? We've identified that these are potential security vulnerabilities so if you could please tag me onto any PRs you open I would appreciate it. I'm also looking at some fixes for the integration tests, in case you've run into any problems running those.

jillr added a commit to jillr/community.aws that referenced this issue Sep 18, 2020
@jillr
aws_ssm: Namespace S3 buckets and delete transferred files
e74e7e5 
Files transferred to instances via the SSM connection plugin should use
folders within the bucket that are namespaced per-host, to prevent collisions.
Files should also be deleted from buckets when they are no longer required.

Fixes: ansible-collections#221
Fixes: ansible-collections#222

Based on work by @abeluck
jillr added a commit to jillr/community.aws that referenced this issue Sep 22, 2020
@jillr
aws_ssm: Namespace S3 buckets and delete transferred files
cb79bf1 
Files transferred to instances via the SSM connection plugin should use
folders within the bucket that are namespaced per-host, to prevent collisions.
Files should also be deleted from buckets when they are no longer required.

Fixes: ansible-collections#221
Fixes: ansible-collections#222

Based on work by @abeluck
@jillr jillr mentioned this issue Sep 22, 2020
Merged
jillr added a commit to jillr/community.aws that referenced this issue Sep 22, 2020
@jillr
aws_ssm: Namespace S3 buckets and delete transferred files
05c28ed 
Files transferred to instances via the SSM connection plugin should use
folders within the bucket that are namespaced per-host, to prevent collisions.
Files should also be deleted from buckets when they are no longer required.

Fixes: ansible-collections#221
Fixes: ansible-collections#222

Based on work by abeluck

changelog
@jillr jillr closed this as completed in #237 Oct 2, 2020
jillr added a commit that referenced this issue Oct 2, 2020
@jillr
aws_ssm: Namespace S3 buckets and delete transferred files (#237)
921bd53 
Files transferred to instances via the SSM connection plugin should use
folders within the bucket that are namespaced per-host, to prevent collisions.
Files should also be deleted from buckets when they are no longer required.

Fixes: #221
Fixes: #222

Based on work by abeluck

changelog
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue Jul 19, 2021
@jillr
aws_ssm: Namespace S3 buckets and delete transferred files (ansible-c…
403208c 
…ollections#237)

Files transferred to instances via the SSM connection plugin should use
folders within the bucket that are namespaced per-host, to prevent collisions.
Files should also be deleted from buckets when they are no longer required.

Fixes: ansible-collections#221
Fixes: ansible-collections#222

Based on work by abeluck

changelog
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue Jul 19, 2021
@jillr
aws_ssm: Namespace S3 buckets and delete transferred files (ansible-c…
66172d0 
…ollections#237)

Files transferred to instances via the SSM connection plugin should use
folders within the bucket that are namespaced per-host, to prevent collisions.
Files should also be deleted from buckets when they are no longer required.

Fixes: ansible-collections#221
Fixes: ansible-collections#222

Based on work by abeluck

changelog
@finswimmer finswimmer mentioned this issue Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jillr jillr

Labels
affects_2.10 bug This issue/PR relates to a bug has_pr needs_triage python3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

aws_ssm: Namespace S3 buckets and delete transferred files jillr/community.aws
3 participants
@abeluck @jillr @ansibullbot