Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSearch, ElasticSearch module #858

Closed
1 task done
sebastien-rosset opened this issue Jan 10, 2022 · 6 comments · Fixed by #859
Closed
1 task done

OpenSearch, ElasticSearch module #858

sebastien-rosset opened this issue Jan 10, 2022 · 6 comments · Fixed by #859
Labels
feature This issue/PR relates to a feature request has_pr

Comments

@sebastien-rosset
Copy link
Contributor

sebastien-rosset commented Jan 10, 2022 •
edited
Loading

Summary

It would be useful to have a ec2_opensearch module to deploy opensearch/elasticsearch clusters. Is it missing because nobody from the community submitted a PR? Or was it intentionally not added? Some other reason?

There is one module outside this repo (https://github.com/fiunchinho/ansible-aws-elasticsearch-module), but it hasn't been updated in the last 3 years.

Issue Type

Feature Idea

Component Name

opensearch

Additional Information



Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
      



  

  @alinabuzachis





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@sebastien-rosset Thank you for this idea. Would you be willing to work on this module and submit a PR?

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @sebastien-rosset





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  

    

  





      


        


  
    

      
          


@sebastien-rosset Thank you for this idea. Would you be willing to work on this module and submit a PR?

Yes



      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @alinabuzachis





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
@sebastien-rosset Awesome! Please feel free to work on it! :-)


I guess you have to open the PR inside this collection https://github.com/ansible-collections/community.aws.


cc @jillr

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @jillr





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

      

      
            jillr
  

      

      

      commented


        Jan 11, 2022


      
    


  





      


        


  
    

      
          
I agree with @alinabuzachis, the new module would go into community.aws.  It should be named opensearch rather than ec2_opensearch as this service does not use the EC2 API.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @alinabuzachis
alinabuzachis




        transferred this issue from ansible-collections/amazon.aws


      Jan 11, 2022

    

  








      

  
      



  

  @sebastien-rosset





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  

    

  





      


        


  
    

      
          


I agree with @alinabuzachis, the new module would go into community.aws. It should be named opensearch rather than ec2_opensearch as this service does not use the EC2 API.




Thanks. So it will be community.aws/plugins/modules/opensearch.py, right? I see some modules are prefixed with aws, some don't.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @markuman





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          


Is it missing because nobody from the community submitted a PR? Or was it intentionally not added? Some other reason?

I see some modules are prefixed with aws, some don't.




I would call it: "grown historically" :)




Thanks. So it will be community.aws/plugins/modules/opensearch.py, right?




right.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @markuman
markuman




          added
  the 

  feature

  This issue/PR relates to a feature request
 label


      Jan 11, 2022

    

  



  

  

    
  


  

      

    @sebastien-rosset
sebastien-rosset



    mentioned this issue
    
      Jan 12, 2022
    





  


  

      
   Merged

  







  




    


  

  

    
  


  

      

    @tremble
tremble



    mentioned this issue
    
      Jan 12, 2022
    





  


  

      
  
  Closed

  





  
  

      
        
      
      

  
    
    
  


    1 task
  





  




    

    


  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Jun 13, 2022
    
    

      


  

    

      


  

      
        @sebastien-rosset
  





      

        
          Add 'opensearch' and 'opensearch_info' modules (#859)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          f985c1a
        
      

    

  

    

      
Add 'opensearch' and 'opensearch_info' modules

SUMMARY


Add opensearch module to create/update AWS OpenSearch/Elasticsearch  domains.
Add opensearch_info module to query AWS OpenSearch/Elasticsearch domains.

Fixes #858
Requires mattclay/aws-terminator#187

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

Creates OpenSearch or ElasticSearch domain.
ADDITIONAL INFORMATION



The minimum version of botocore for these modules is 1.21.38.
The integration tests take more than 4 hours to execute. Tests time out in the CI. I was able to run the integration tests locally.

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Sebastien Rosset <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <git@osuv.de>

    




    

  




  


  
    
  
  

    
  abikouo 

      pushed a commit
        to abikouo/community.aws
      that referenced
      this issue

    
      Oct 24, 2023
    
    

      


  

    

      


  

      
        @alinabuzachis
  





      

        
          Add version_added: 1.5.0 for exclude_filters, include_filters and use…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          5f05853
        
      

    

  

    

      
…_contrib_script_compatible_ec2_tag_keys (ansible-collections#858)

Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys

SUMMARY

Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys
include_filters and exclude_filters have been added ansible-collections#328 and released with amazon.aws 1.5.0
use_contrib_script_compatible_ec2_tag_keys has been added ansible-collections#331 and released with  amazon.aws 1.5.0
Let's update the aws_ec2 inventory plugin documentation with this information.
This should be a step towards closing this one ansible-collections#676 and ansible-collections#675
aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR.

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

aws_ec2
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    feature

  This issue/PR relates to a feature request
  

    has_pr









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




            
Successfully merging a pull request may close this issue.





    


  
          
      Add 'opensearch' and 'opensearch_info' modules

    
      CiscoM31/community.aws
    





    
  




        
      

    

  
      

  

    

      4 participants
    

    

        
          @markuman 
        
          @jillr 
        
          @sebastien-rosset 
        
          @alinabuzachis