Add support for load_balancing_algorithm_type in elb_target_group #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
|
I've tried that also in the past #282
So when a target group is attached to a classic loadbalancer, or to an NLB, it will fail. |
|
@markuman i think that's fine, I'll document it so it's clear, there's another example already in the module "deregistration_connection_termination" that only applies to NLB We could also limit to if protocol is http / https I think but probably documenting is enough |
marknet15
force-pushed
the
add-lb-algo-support
branch
from
754d3bb
to
f906a1f
Compare
markuman
reviewed
Mar 26, 2022
alinabuzachis
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
@marknet15 Thank you. Only two very small things, otherwise, LGTM!
Co-authored-by: Alina Buzachis <abuzachis@redhat.com>
Co-authored-by: Alina Buzachis <abuzachis@redhat.com>
markuman
approved these changes
Mar 28, 2022
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1022 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
) Add support for load_balancing_algorithm_type in elb_target_group SUMMARY AWS has supported setting the load_balancing.algorithm.type for a little while now allowing you to choose between either round_robin or least_oustanding_requests this PR adds support for setting the new parameter. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group ADDITIONAL INFORMATION https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.modify_target_group_attributes https://aws.amazon.com/about-aws/whats-new/2019/11/application-load-balancer-now-supports-least-outstanding-requests-algorithm-for-load-balancing-requests/ Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> (cherry picked from commit 10137a2)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
) (#1022) [PR #1016/10137a2a backport][stable-3] Add support for load_balancing_algorithm_type in elb_target_group This is a backport of PR #1016 as merged into main (10137a2). SUMMARY AWS has supported setting the load_balancing.algorithm.type for a little while now allowing you to choose between either round_robin or least_oustanding_requests this PR adds support for setting the new parameter. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group ADDITIONAL INFORMATION https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.modify_target_group_attributes https://aws.amazon.com/about-aws/whats-new/2019/11/application-load-balancer-now-supports-least-outstanding-requests-algorithm-for-load-balancing-requests/
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Add changelog and update FQDN SUMMARY Update FQDN and add missing changelog ansible-collections#997 ISSUE TYPE Docs Pull Request COMPONENT NAME cloudtrail Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
AWS has supported setting the
load_balancing.algorithm.typefor a little while now allowing you to choose between eitherround_robinorleast_oustanding_requeststhis PR adds support for setting the new parameter.ISSUE TYPE
COMPONENT NAME
elb_target_group
ADDITIONAL INFORMATION
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.modify_target_group_attributes
https://aws.amazon.com/about-aws/whats-new/2019/11/application-load-balancer-now-supports-least-outstanding-requests-algorithm-for-load-balancing-requests/