Backport: Refactor s3_bucket_notifications to support SNS / SQS (#940) #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions#940) Refactor s3_bucket_notifications to support SNS / SQS SUMMARY Refactor s3_bucket_notifications to extend module to support the extra targets of SNS and SQS along with the currently supported Lambda functions. Summary of changes: Refactor module to support SNS/SQS targets along with current Lambda function support. Fix check mode coverage Update integration tests to more comprehensive cover functionality. Update documentation in sns_topic and sqs_queue modules to add policy setting example. Fixes: ansible-collections#140 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_bucket_notifications ADDITIONAL INFORMATION https://boto3.amazonaws.com/v1/documentation/api/1.16.0/reference/services/s3.html#S3.Client.put_bucket_notification_configuration Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Markus Bergholz <git@osuv.de> (cherry picked from commit dd89ed1)
marknet15
changed the title
marknet15
changed the title
|
hmmm there was a |
|
ah, conflicts... |
ansibullbot
added
community_review
feature
ansibullbot
added
needs_rebase
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
marknet15
deleted the
patchback/backports/stable-3/dd89ed152413dad7b1d0a84049a9f647221eedb6/pr-940
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…#1025) Cleanup after 4.2.0 Release SUMMARY With 4.2.0 tagged we now need to forward-port the changelog updates from 4.2.0 ISSUE TYPE Docs Pull Request COMPONENT NAME CHANGELOG.rst changelogs/changelog.yaml changelogs/fragments/ ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Backport #940 manually to resolve conflict
ISSUE TYPE
COMPONENT NAME
s3_bucket_notification
ADDITIONAL INFORMATION