Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1054/ce418676 backport][stable-2] iam_role - delete inline policies, stabilize for migration to amazon.aws #1062

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Apr 13, 2022

This is a backport of PR #1054 as merged into main (ce41867).

SUMMARY

Stabilize for migration to amazon.aws

  • delete inline policies before deleting the role
  • removed global vars and refactored function definitions
  • added some extra integration tests for check mode
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iam_role

…aws (#1054)

iam_role - delete inline policies, stabilize for migration to amazon.aws

SUMMARY
Stabilize for migration to amazon.aws

delete inline policies before deleting the role
removed global vars and refactored function definitions
added some extra integration tests for check mode

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_role

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
(cherry picked from commit ce41867)
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Apr 13, 2022
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 14, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a334f70 into stable-2 Apr 14, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-2/ce4186763f5fecf45642bf956588afb659640e05/pr-1054 branch April 14, 2022 08:11
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants