ec2_asg: Change purge_tags default value to False #1064
Conversation
ansibullbot
added
bug
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
|
@mandar242 @alinabuzachis @jillr once this is merged, do we ship it with |
I put this to the agenda for the next meeting. |
|
regate |
|
Shouldn't this have a changelog fragment so that users know what happens? |
yeah. good point. It can be added in the release PR, which also needs to be approved and where some extra notes should be left in the |
|
I've pushed a changelog fragment. It needs some reviews again @tremble @marknet15 @felixfontein |
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1069 🤖 @patchback |
ec2_asg: Change purge_tags default value to False SUMMARY Changed default value of purge_tags to False. With the addition of purge_tags to ec2_asg module #960, the default value was kept to True similar to many other modules in this collection and also as specified in ansible dev guide. With this addition, the issue was discovered that there is a possibility of this change breaking existing playbooks for users if they don't update their playbooks and specify purge_tags: false where required. This PR's change will prevent accidental breakage. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_asg Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> (cherry picked from commit d0c9f1a)
[PR #1064/d0c9f1a6 backport][stable-3] ec2_asg: Change purge_tags default value to False This is a backport of PR #1064 as merged into main (d0c9f1a). SUMMARY Changed default value of purge_tags to False. With the addition of purge_tags to ec2_asg module #960, the default value was kept to True similar to many other modules in this collection and also as specified in ansible dev guide. With this addition, the issue was discovered that there is a possibility of this change breaking existing playbooks for users if they don't update their playbooks and specify purge_tags: false where required. This PR's change will prevent accidental breakage. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_asg Reviewed-by: Mark Chappell <None>
SUMMARY
Changed default value of
purge_tagstoFalse.With the addition of
purge_tagstoec2_asgmodule #960, the default value was kept toTruesimilar to many other modules in this collection and also as specified in ansible dev guide.With this addition, the issue was discovered that there is a possibility of this change breaking existing playbooks for users if they don't update their playbooks and specify
purge_tags: falsewhere required.This PR's change will prevent accidental breakage.
ISSUE TYPE
COMPONENT NAME
ec2_asg