[PR #1068/8d80e9a0 backport][stable-2] Revert breaking change - iam_role return values #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Revert breaking change - iam_role return values SUMMARY This hasn't been release yet, so a changelog isn't needed. While I'm generally good with cleaning up the output values here, this needs to be done as a separate breaking change, and must not be backported to stable-3. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION Breaking change silently introduced by #1054 Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 8d80e9a)
tremble
approved these changes
Apr 14, 2022
ansibullbot
added
bug
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-2/8d80e9a062b166065c9a96fbf6d774d5d7375619/pr-1068
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ctions#1073) Make example AWS UUIDS follow a specific pattern - RDS SUMMARY Various AWS IAM resources have UUID which follow a specific pattern. Similarly AWS accounts are all 12 digit numbers (text aliases in a couple of cases). To minimize the risk of accidental data leaks use a consistent Account ID in examples (123456789012), and a specific format for the UUIDS: (AKIA|AGPA|AIDA|AROA|AIPA|ANPA|ANVA|ASIA)12345EXAMPLE54321 While this does nothing about historic data, having consistency makes it easier to prevent future leaks. Note: We should follow this up with an update to the developer docs, however I'd like to get this in prior to 5.0.0 Split from ansible-collections#1070 due to test concurrency problems ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/rds_instance_info.py plugins/modules/rds_option_group.py plugins/modules/rds_option_group_info.py plugins/modules/rds_snapshot_info.py plugins/modules/rds_subnet_group.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…#1070) Make example AWS UUIDS follow a specific pattern SUMMARY Various AWS IAM resources have UUID which follow a specific pattern. Similarly AWS accounts are all 12 digit numbers (text aliases in a couple of cases). To minimize the risk of accidental data leaks use a consistent Account ID in examples (123456789012), and a specific format for the UUIDS: (AKIA|AGPA|AIDA|AROA|AIPA|ANPA|ANVA|ASIA)12345EXAMPLE54321 While this does nothing about historic data, having consistency makes it easier to prevent future leaks. Note: We should follow this up with an update to the developer docs, however I'd like to get this in prior to 5.0.0 ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/autoscaling_group_info.py plugins/modules/cloudformation.py plugins/modules/ec2_ami.py plugins/modules/ec2_ami_info.py plugins/modules/ec2_eni_info.py plugins/modules/ec2_instance.py plugins/modules/ec2_instance_info.py plugins/modules/ec2_metadata_facts.py plugins/modules/ec2_security_group.py plugins/modules/ec2_security_group_info.py plugins/modules/ec2_snapshot_info.py plugins/modules/elb_application_lb.py plugins/modules/elb_application_lb_info.py plugins/modules/iam_user_info.py plugins/modules/kms_key.py plugins/modules/kms_key_info.py plugins/modules/lambda.py plugins/modules/rds_instance_info.py plugins/modules/rds_option_group.py plugins/modules/rds_option_group_info.py plugins/modules/rds_snapshot_info.py plugins/modules/rds_subnet_group.py ADDITIONAL INFORMATION While the 'secret' nature of these UUIDs is debatable (they're closer to user names than passwords), deliberately mangling them makes it easier for InfoSec teams to spot when their secret counterparts may have been leaked in combination with a real 'public' part. Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1068 as merged into main (8d80e9a).
SUMMARY
This hasn't been release yet, so a changelog isn't needed.
While I'm generally good with cleaning up the output values here, this needs to be done as a separate breaking change, and must not be backported to stable-3.
ISSUE TYPE
COMPONENT NAME
iam_role
ADDITIONAL INFORMATION
Breaking change silently introduced by #1054