Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1068/8d80e9a0 backport][stable-3] Revert breaking change - iam_role return values #1071

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Apr 14, 2022

This is a backport of PR #1068 as merged into main (8d80e9a).

SUMMARY

This hasn't been release yet, so a changelog isn't needed.

While I'm generally good with cleaning up the output values here, this needs to be done as a separate breaking change, and must not be backported to stable-3.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iam_role

ADDITIONAL INFORMATION

Breaking change silently introduced by #1054

Revert breaking change - iam_role return values

SUMMARY
This hasn't been release yet, so a changelog isn't needed.
While I'm generally good with cleaning up the output values here, this needs to be done as a separate breaking change, and must not be backported to stable-3.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
iam_role
ADDITIONAL INFORMATION
Breaking change silently introduced by #1054

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
(cherry picked from commit 8d80e9a)
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 14, 2022
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Apr 14, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 8c84211 into stable-3 Apr 14, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-3/8d80e9a062b166065c9a96fbf6d774d5d7375619/pr-1068 branch April 14, 2022 15:30
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…ble-collections#1071)

Handle ec2_vol.tags when the associated instance already exists

Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY


Fixes ansible-collections#1067
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_vol.py
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: GomathiselviS <None>
Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants