Tagging - Add simple deprecations for purge_tags=False #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
tagging/deprecate_purge/simple
branch
from
15b8949
to
381d3cb
Compare
ansibullbot
added
community_review
feature
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
tagging/deprecate_purge/simple
branch
from
381d3cb
to
3389e12
Compare
markuman
approved these changes
May 31, 2022
alinabuzachis
approved these changes
May 31, 2022
This comment was marked as outdated.
This comment was marked as outdated.
|
regate |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 23, 2022
[stable-3] Fixup short description for aws_acm SUMMARY Fixup short description for aws_acm partial backport from #1185 ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/aws_acm.py ADDITIONAL INFORMATION > (as opposed to >-) results in a weird extra new line in the generated docs Reviewed-by: Alina Buzachis <None>
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ctions#1185) Tagging - Add simple deprecations for purge_tags=False Depends-On: ansible-collections/amazon.aws#844 SUMMARY Deprecate the use of purge_tags=False as a default ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_acm.py plugins/modules/route53_health_check.py plugins/modules/route53_zone.py plugins/modules/sqs_queue.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@42688f3
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
rds_instance: split up the integration tests Split the rds_instance target in smaller targets. Reviewed-by: Alina Buzachis <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
rds - add the engine_mode parameter Depends-On: ansible-collections#1185 Add a new engine_mode parameter to rds_cluster and also adjust the test-suite follow-up to some recent API changes: With the aurora engine, engine_mode default now on serverless. We cannot adjust the endpoint_port of a serverless cluster. aurora clusters are now encrypted by default (storage_encrypted) The new engine_mode parameter also allows us to re-enable the Aurora test of the rds_instance integration tests. Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible-collections/amazon.aws#844
SUMMARY
Deprecate the use of purge_tags=False as a default
ISSUE TYPE
COMPONENT NAME
plugins/modules/aws_acm.py
plugins/modules/route53_health_check.py
plugins/modules/route53_zone.py
plugins/modules/sqs_queue.py
ADDITIONAL INFORMATION