[PR #1187/029333b3 backport][stable-2] ecs_service and ecs_service_info: add name and service aliases #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
ecs_service and ecs_service_info: add name and service aliases SUMMARY while ecs_service is using name for the service name parameter, ecs_service_info is using service for the same purpose. this PR adds just aliases to both modules, to use the same parameter to address the ecs service name. ref #1142 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ecs_service_info Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit 029333b)
ansibullbot
added
bug
markuman
approved these changes
Jun 2, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-2/029333b3a974c1f31c27b1a2e9e7a1399733d857/pr-1187
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
) rds_instance: disable aurora integration tests Follow up to a recent behaviour change, the Aurora clusters are created with engine_mode=serverless by default. When we try to add a new instance with rds_instance, we get the following errror: Unable to create DB instance: An error occurred (InvalidParameterValue) when calling the CreateDBInstance operation: Instances cannot be added to Aurora Serverless clusters. e.g: https://ansible.softwarefactory-project.io/zuul/build/f1f7cb085f0c4038b905a216a118c229/logs Address the problem, we will need to add the engine_mode parameter to rds_cluster through ansible-collections#941 and adjust the test-suite. This commit temporarily disable the aurora integration tests for now. Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1187 as merged into main (029333b).
SUMMARY
while
ecs_serviceis usingnamefor the service name parameter,ecs_service_infois usingservicefor the same purpose.this PR adds just aliases to both modules, to use the same parameter to address the ecs service name.
ref #1142
ISSUE TYPE
COMPONENT NAME
ecs_service
ecs_service_info