sns_topic - Fix bug when used in GovCloud - issue 836 #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razique
commented
Jun 2, 2022
ansibullbot
added
bug
tremble
requested changes
Jun 13, 2022
ansibullbot
added
needs_revision
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
and removed
needs_revision
tremble
reviewed
Jun 28, 2022
|
There was an error handling pipeline event 2339f52e-ad70-4330-95fd-93d2faff75c3. |
tremble
reviewed
Jun 28, 2022
tremble
approved these changes
Jun 28, 2022
tremble
changed the title
tremble
reviewed
Jun 29, 2022
|
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1275 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
SUMMARY Add region detection to skip usage of FIFO topics when using GovCloud regions Fixes #836 ISSUE TYPE Bugfix Pull Request COMPONENT NAME community.aws.sns_topic * * Add endpoint detection to skip usage of FIFO topics for GovCloud regions * * Remove GovCloud hack for FIFO topics * Update plugins/modules/sns_topic.py * Update plugins/modules/sns_topic.py * minor docs tweak (cherry picked from commit 2d74eda)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
Add missing changelog fragment for 1195 SUMMARY Forgot to add a changelog fragment for #1195 ISSUE TYPE Docs Pull Request COMPONENT NAME sns_topic ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
…in GovCloud - issue 836 (#1275) [PR #1195/2d74eda7 backport][stable-4] sns_topic - Fix bug when used in GovCloud - issue 836 This is a backport of PR #1195 as merged into main (2d74eda). SUMMARY Add region detection to skip usage of FIFO topics when using GovCloud regions Fixes #836 ISSUE TYPE Bugfix Pull Request COMPONENT NAME community.aws.sns_topic Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…1195) ec2_vpc_endpoint - Remove policy_file parameter SUMMARY fixes: ansible-collections#1178 Drops the previously deprecated policy_file parameter. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_endpoint ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add region detection to skip usage of FIFO topics when using GovCloud regions
Fixes #836
ISSUE TYPE
COMPONENT NAME
community.aws.sns_topic