Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging fragment - dynamodb_table - Move over to the docs fragment. #1199

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 2, 2022

SUMMARY

The dynamodb tests are slow enough to cause test timeouts when combined with too many other changed, split this off.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

dynamodb_table

ADDITIONAL INFORMATION

The change itself was approved on #1182

@tremble tremble force-pushed the tagging/docs_slow/dynamodb_table branch from c83314d to 9ed54f1 Compare June 2, 2022 07:28
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jun 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 29s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 42s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 42s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 52s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 41s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 14m 45s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 20s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 51s
✔️ ansible-test-splitter SUCCESS in 2m 25s
✔️ integration-community.aws-1 SUCCESS in 30m 16s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 2, 2022
@tremble
Copy link
Contributor Author

tremble commented Jun 2, 2022

I'm going to merge this based on the change having originally been in place when the approvals on #1182 were added. The code didn't change, we just needed to split up the running of the tests.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 56s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 00s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 29s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 30s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 57s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 13m 07s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 03s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 06s
✔️ ansible-test-splitter SUCCESS in 2m 29s
✔️ integration-community.aws-1 SUCCESS in 56m 14s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 934e330 into ansible-collections:main Jun 2, 2022
@tremble tremble deleted the tagging/docs_slow/dynamodb_table branch July 7, 2022 19:23
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…s#1199)

ec2_instance - validate options on tower_callback

Depends-On: ansible-collections#1202
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants