ecs_* - fix idempotence bug in ecs_service and dont require cluster
#1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Merged
markuman
added
backport-2
markuman
approved these changes
Jun 4, 2022
alinabuzachis
approved these changes
Jun 8, 2022
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #1230 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
…`` (#1212) ecs_* - fix idempotence bug in ecs_service and dont require ``cluster`` SUMMARY Don't require cluster param and use cluster name 'default' when not specified (see docs). Fix bug when comparing health_check_grace_period_seconds when not input by user. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_service ecs_task ADDITIONAL INFORMATION Split up from #1209 to backport to stable-2 Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> (cherry picked from commit bac2473)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1231 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
…`` (#1212) ecs_* - fix idempotence bug in ecs_service and dont require ``cluster`` SUMMARY Don't require cluster param and use cluster name 'default' when not specified (see docs). Fix bug when comparing health_check_grace_period_seconds when not input by user. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_service ecs_task ADDITIONAL INFORMATION Split up from #1209 to backport to stable-2 Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> (cherry picked from commit bac2473)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 15, 2022
…`` (#1212) (#1231) [PR #1212/bac24736 backport][stable-3] ecs_* - fix idempotence bug in ecs_service and dont require ``cluster`` This is a backport of PR #1212 as merged into main (bac2473). SUMMARY Don't require cluster param and use cluster name 'default' when not specified (see docs). Fix bug when comparing health_check_grace_period_seconds when not input by user. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_service ecs_task ADDITIONAL INFORMATION Split up from #1209 to backport to stable-2 Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 15, 2022
…`` (#1212) (#1230) [PR #1212/bac24736 backport][stable-2] ecs_* - fix idempotence bug in ecs_service and dont require ``cluster`` This is a backport of PR #1212 as merged into main (bac2473). SUMMARY Don't require cluster param and use cluster name 'default' when not specified (see docs). Fix bug when comparing health_check_grace_period_seconds when not input by user. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_service ecs_task ADDITIONAL INFORMATION Split up from #1209 to backport to stable-2 Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
[PR #1209/cff148f0 backport][stable-4] ecs_* - add waiters This is a backport of PR #1209 as merged into main (cff148f). Originally-Depends-On: #1212 SUMMARY Add wait parameter to utilize boto3 waiters in ecs_service and ecs_task (ServicesInactive, TasksStopped, TasksRunning). There's an additional waiter for ServicesStable but idempotence checked never failed locally so it seems redundant when creating a service. Ref #1142 ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ecs_task ADDITIONAL INFORMATION When testing the waiter for TasksRunning, tests failed on waiter error due to the container instance not being able to be created, not because of the waiter, so I commented out those tests for now. In the ECS console: Stopped reason CannotPullContainerError: inspect image has been retried 5 time(s): failed to resolve ref "docker.io/library/nginx:latest": failed to do request: Head https://registry-1.docker.io/v2/library/nginx/manifests/latest: dial tcp 34.237.244.67:443: i/o timeout Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
clusterparam and use cluster name 'default' when not specified (see docs).health_check_grace_period_secondswhen not input by user.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Split up from #1209 to backport to stable-2