cloudwatchlogs_log_group - Tagging support #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g_group returns promised values
ansibullbot
added
WIP
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
tagging/purge_tags/cloudwatchlogs_log_group
branch
from
1a2d4b2
to
258f4d5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
changed the title
tremble
force-pushed
the
tagging/purge_tags/cloudwatchlogs_log_group
branch
from
258f4d5
to
94f60b2
Compare
jatorcasso
reviewed
Jun 10, 2022
| return dict(log_groups=[log_group], **log_group) | ||
|
|
||
|
|
||
| def ensure_tags(client, found_log_group, desired_tags, purge_tags, module): |
There was a problem hiding this comment.
we could probably change the params here to (client, log_group_name, current_tags, desired_tags, purge_tags, module) to avoid passing in the entire found_log_group when we dont need it, but thats probably a preference thing. just a thought
There was a problem hiding this comment.
I'm not bothered either way.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Joseph Torcasso <87090265+jatorcasso@users.noreply.github.com>
tremble
force-pushed
the
tagging/purge_tags/cloudwatchlogs_log_group
branch
from
41a8c2e
to
894f21d
Compare
|
Re check mode, my thought was deal with it later, wanted to try and get this tagging cleanup in place for 4.0.0 A general cleanup of check mode's probably going to be a sizable chunk of work. There's around 50 modules missing support. |
jatorcasso
approved these changes
Jun 11, 2022
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
cloudwatchlogs_log_group - Tagging support SUMMARY Ensure cloudwatchlogs_log_group returns values defined in RETURN docs Add support for updating tags (including purge_tags) split cloudwatchlogs_log_group tests Add some basic integration tests for cloudwatchlogs_log_group_info ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME cloudwatchlogs_log_group cloudwatchlogs_log_group_info ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@3f8d2fc
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
rds/tests: use aurora2 cluster by default Aurora1 (provisioned and serverless) which comes with MySQL 5.6 will be soon deprecated by AWS. See: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.MySQL56.EOL.html This commit also reverses change 8e7ac73. Closes: ansible-collections#1228 Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
cloudwatchlogs_log_group
cloudwatchlogs_log_group_info
ADDITIONAL INFORMATION