Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1384/569fff4c backport][stable-3] route53_info - fix max_items when not paginating #1387

Commits on Aug 2, 2022

  1. route53_info - fix max_items when not paginating (#1384)

    route53_info - fix max_items when not paginating
    
    SUMMARY
    As reported in #1383, the route53_info module presently fails to run with a boto3 parameter validation error if run with particular combinations of parameters, specifically:
    
    query: hosted_zone parameter with hosted_zone_method: list_by_name
    query: reusable_delegation_set without specifying a delegation_set_id
    
    I believe this is a regression introduced in #813
    ISSUE TYPE
    
    Bugfix Pull Request
    
    COMPONENT NAME
    route53_info
    ADDITIONAL INFORMATION
    Some further information is described in the issue but tl;dr the prior PR converted all cases in the module where params['MaxItems'] was set to instead pass a params['PaginationConfig'], however this should only be done if a boto3 paginator is actually being used, and will fail (as noted above, due to parameter validation) if called with a regular boto3 client method.
    Hence this PR switches back to directly setting MaxItems on the methods that do not use a paginator.
    
    Reviewed-by: Mark Chappell <None>
    (cherry picked from commit 569fff4)
    mcoot authored and patchback[bot] committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    2fd7a4c View commit details
    Browse the repository at this point in the history