backport-4: Minor fixups (#1328) #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecs_service - Minor fixups SUMMARY Bad rebase resulted in a duplicated parameter Fixup "changed" after adding initial support for tags ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Bugs aren't in a released version yet, no need for changelog Reviewed-by: Joseph Torcasso <None>
ansibullbot
added
bug
|
recheck |
tremble
approved these changes
Aug 4, 2022
ansibullbot
added
needs_revision
ansibullbot
added
community_review
and removed
needs_revision
tremble
approved these changes
Aug 4, 2022
|
Tests passing locally (fail without the patch) |
softwarefactory-project-zuul
bot
merged commit b772c39
into
ansible-collections:stable-4
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…lections#1394) Cleanup and move tasks (vs playbooks) in inventory tests SUMMARY Inventory plugin tests currently mix "tasks" content in with playbooks, this triggers ansible-lint warnings. ISSUE TYPE Tests Pull Request COMPONENT NAME ec2_vpc_net plugins/inventory/aws_ec2.py plugins/inventory/aws_rds.py ADDITIONAL INFORMATION Spotted by work on ansible-collections#1393 Reviewed-by: Alina Buzachis
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Minor Sanity test fixes SUMMARY Steal sanity fixes from ansible-collections#1393 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/backup_tag_info.py plugins/modules/backup_vault.py plugins/modules/route53_info.py test-requirements.txt ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
SUMMARY
Add github action workflow.
ISSUE TYPE
Feature Pull Request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forgotten backport-4 breaks
ecs_servicein 4.1.0after it's merged, 4.1.1 must be released asap
ecs_service - Minor fixups
SUMMARY
Bad rebase resulted in a duplicated parameter
Fixup "changed" after adding initial support for tags
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
ecs_service
ADDITIONAL INFORMATION
Bugs aren't in a released version yet, no need for changelog
Reviewed-by: Joseph Torcasso
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION