Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1692/5bf51c0d backport][stable-5] iam_role - add assume_role_policy_document_raw #1694

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Feb 2, 2023

This is a backport of PR #1692 as merged into main (5bf51c0).

SUMMARY

fixes: #551

assume_role_policy_document is an IAM policy document, and as such we shouldn't be modifying it. Running camel / snake conversion against the document breaks it. Adds assume_role_policy_document_raw and deprecates the current snake_case behaviour.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iam_role
iam_role_info

ADDITIONAL INFORMATION

Follows up on #1054 / #1068

iam_role - add assume_role_policy_document_raw

SUMMARY
fixes: #551
assume_role_policy_document is an IAM policy document, and as such we shouldn't be modifying it.  Running camel / snake conversion against the document breaks it.  Adds assume_role_policy_document_raw and deprecates the current snake_case behaviour.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_role
iam_role_info
ADDITIONAL INFORMATION
Follows up on #1054 / #1068

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 5bf51c0)
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Feb 2, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 33s
✔️ build-ansible-collection SUCCESS in 5m 38s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 00s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 59s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 04s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 37s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 36s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 05s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 46s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 40s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 53s
✔️ ansible-test-changelog SUCCESS in 2m 23s
✔️ ansible-test-splitter SUCCESS in 2m 53s
✔️ integration-community.aws-1 SUCCESS in 5m 03s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e83ff94 into stable-5 Feb 2, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/5bf51c0d05376434bb945c43589fd6e4dcd89bc4/pr-1692 branch February 2, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants