Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add route53_wait module #1904

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Add route53_wait module #1904

merged 1 commit into from
Sep 5, 2023

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Aug 2, 2023 •
edited
Loading

SUMMARY

Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false.

Depends on ansible-collections/amazon.aws#1683, thus the tests shouldn't really do anything right now.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

route53

@felixfontein felixfontein added the backport-6 PR should be backported to the stable-6 branch label Aug 2, 2023
@felixfontein felixfontein mentioned this pull request Aug 2, 2023
Merged
@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress integration tests/integration module module new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Aug 2, 2023
@felixfontein felixfontein mentioned this pull request Aug 2, 2023
Closed
@github-actions
Copy link

github-actions bot commented Aug 2, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f4b39b08c5e54e9191a6f810afb77db1

✔️ ansible-galaxy-importer SUCCESS in 3m 40s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 08s
✔️ ansible-test-splitter SUCCESS in 5m 25s
❌ integration-community.aws-1 FAILURE in 8m 05s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/8946663f7dfc4efe839c234f413e1ff3

✔️ ansible-galaxy-importer SUCCESS in 3m 50s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 34s
✔️ ansible-test-splitter SUCCESS in 5m 06s
❌ integration-community.aws-1 FAILURE in 8m 40s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5daa255722c743e4b66cc480dbdc2e5f

✔️ ansible-galaxy-importer SUCCESS in 4m 13s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 45s
✔️ ansible-test-splitter SUCCESS in 5m 03s
❌ integration-community.aws-1 FAILURE in 8m 24s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e3a2ddfa247e4eef8dcb4ded11ddb88f

❌ ansible-galaxy-importer FAILURE in 4m 43s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 41s
✔️ ansible-test-splitter SUCCESS in 5m 28s
❌ integration-community.aws-1 FAILURE in 8m 50s
Skipped 21 jobs

@felixfontein
Copy link
Contributor Author

felixfontein commented Aug 3, 2023 •
edited
Loading

(https://2e4228b6a20b96c9daa7-f0073ffe67d5b572affa5da07fbe4f37.ssl.cf2.rackcdn.com/1904/3a596df43a9d7f5eff80702ab04a6f8d406a83cd/check/integration-community.aws-1/e2ba4bd/job-output.txt)

"msg": "Timeout waiting for resource records changes to be applied: Waiter resource_record_sets_changed failed: An error occurred (AccessDenied): User: arn:aws:sts::966509639900:assumed-role/ansible-core-ci-test-prod/prod=remote=zuul-cloud is not authorized to perform: route53:GetChange on resource: arn:aws:route53:::change/C06400651MBI4Q3GLGAHH because no identity-based policy allows the route53:GetChange action",

It looks like the user has no authorization to check progress for Route53 updates. I checked the route53 tests (in amazon.aws), none of them uses wait: true (which would very likely cause the same error).

@felixfontein felixfontein mentioned this pull request Aug 4, 2023
Closed
@felixfontein
Copy link
Contributor Author

I created mattclay/aws-terminator#288 to update the permissions.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a503da5f168340c6a099928f9795b4e1

❌ ansible-galaxy-importer FAILURE in 4m 16s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 42s
✔️ ansible-test-splitter SUCCESS in 5m 33s
❌ integration-community.aws-1 FAILURE in 7m 46s
Skipped 21 jobs

@felixfontein
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/8099707f0d7e40c08cbd4f6d8d47ff44

❌ ansible-galaxy-importer FAILURE in 4m 17s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 35s
✔️ ansible-test-splitter SUCCESS in 5m 27s
❌ integration-community.aws-1 RETRY_LIMIT in 4m 46s
Skipped 21 jobs

@felixfontein
Copy link
Contributor Author

Integration tests should now have a chance to complete, due to mattclay/aws-terminator#290. Unfortunately they currently do not run due to Python 3.9 being used with ansible-core devel/milestone.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f1ba6ceaa7ad434e86f7a9933c66c3f7

❌ ansible-galaxy-importer FAILURE in 4m 49s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 27s
✔️ ansible-test-splitter SUCCESS in 5m 31s
❌ integration-community.aws-1 RETRY_LIMIT in 8m 14s
Skipped 21 jobs

@tremble
Copy link
Contributor

tremble commented Aug 11, 2023

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4902e9b4cc6544988a7a7d154d363295

✔️ ansible-galaxy-importer SUCCESS in 3m 51s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 39s
✔️ ansible-test-splitter SUCCESS in 4m 46s
❌ integration-community.aws-1 RETRY_LIMIT in 5m 22s
Skipped 21 jobs

@felixfontein felixfontein mentioned this pull request Aug 11, 2023
Merged
@felixfontein
Copy link
Contributor Author

I tested this module today with felixfontein/ansible-acme#62 to generate a larger set of certificates, and all worked well. Using this module instead of adding wait: true in the loop over amazon.aws.route53 significantly speeds things up.

@felixfontein felixfontein changed the title [WIP] Add route53_wait module Add route53_wait module Aug 11, 2023
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Aug 11, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a99b09a05a5e40699c8394221882b426

✔️ ansible-galaxy-importer SUCCESS in 4m 17s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 07s
✔️ ansible-test-splitter SUCCESS in 4m 48s
❌ integration-community.aws-1 RETRY_LIMIT in 5m 09s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f47e3d5661ef4f46ad5dd151a58daf07

✔️ ansible-galaxy-importer SUCCESS in 4m 43s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 21s
✔️ ansible-test-splitter SUCCESS in 4m 39s
❌ integration-community.aws-1 FAILURE in 8m 49s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/bc80b405d6054f0097f19556f94b3fd2

❌ ansible-galaxy-importer FAILURE in 5m 11s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 51s
✔️ ansible-test-splitter SUCCESS in 5m 08s
❌ integration-community.aws-1 FAILURE in 11m 06s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/39539b71f1ef40438668e0eb2fa76bec

✔️ ansible-galaxy-importer SUCCESS in 4m 06s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 17s
✔️ ansible-test-splitter SUCCESS in 4m 45s
✔️ integration-community.aws-1 SUCCESS in 10m 53s
Skipped 21 jobs

@felixfontein felixfontein marked this pull request as ready for review August 24, 2023 12:14
@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Sep 5, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/1af3ba38df084234a75af64855164a16

✔️ ansible-galaxy-importer SUCCESS in 3m 48s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 35s
✔️ ansible-test-splitter SUCCESS in 5m 05s
✔️ integration-community.aws-1 SUCCESS in 7m 38s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a7cddf0 into ansible-collections:main Sep 5, 2023
57 checks passed
@patchback
Copy link

patchback bot commented Sep 5, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/a7cddf0ee711ca88efbcc23560557b0f338eae10/pr-1904

Backported as #1927

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 5, 2023
@felixfontein @patchback
Add route53_wait module. (#1904)
168509b 
Add route53_wait module

SUMMARY
Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false.
Depends on ansible-collections/amazon.aws#1683, thus the tests shouldn't really do anything right now.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
route53

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis
(cherry picked from commit a7cddf0)
@patchback patchback bot mentioned this pull request Sep 5, 2023
Merged
@felixfontein felixfontein deleted the route53_wait branch September 5, 2023 21:42
@felixfontein
Copy link
Contributor Author

@tremble @markuman @alinabuzachis thanks a lot for your help getting this merged!

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 6, 2023
@patchback
Add route53_wait module. (#1904) (#1927)
bfaa87c 
[PR #1904/a7cddf0e backport][stable-6] Add route53_wait module

This is a backport of PR #1904 as merged into main (a7cddf0).
SUMMARY
Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false.
Depends on ansible-collections/amazon.aws#1683, thus the tests shouldn't really do anything right now.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
route53

Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuman markuman markuman approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
backport-6 PR should be backported to the stable-6 branch community_review has_issue integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@felixfontein @ansibullbot @tremble @markuman @alinabuzachis