Add source_version param to ec2_launch_template module #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luiseterc
force-pushed
the
feature/ec2_launch_template_source_version
branch
from
cd0623d
to
027fb6c
Compare
ansibullbot
added
affects_2.10
community_review
feature
|
Hi @luiseterc, Thank you for the PR! Can you please add a changelog (https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs) entry and extend the existing functional tests. |
tremble
force-pushed
the
feature/ec2_launch_template_source_version
branch
from
027fb6c
to
2ea4c14
Compare
tremble
approved these changes
Jul 1, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
markuman
approved these changes
Jul 1, 2022
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1295 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
Add source_version param to ec2_launch_template module SUMMARY Add support for Boto3.create_launch_template_version's source_version parameter. Accepted values: int (specific version) : Creates a new launch template using this version as the base, hence keeping all its parameters string ( 'latest') : Uses the latest found in list template_versions ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_launch_template.py ADDITIONAL INFORMATION Sanity tests passed for this module. Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 279bbc9)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jul 2, 2022
[PR #239/279bbc98 backport][stable-4] Add source_version param to ec2_launch_template module This is a backport of PR #239 as merged into main (279bbc9). SUMMARY Add support for Boto3.create_launch_template_version's source_version parameter. Accepted values: int (specific version) : Creates a new launch template using this version as the base, hence keeping all its parameters string ( 'latest') : Uses the latest found in list template_versions ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_launch_template.py ADDITIONAL INFORMATION Sanity tests passed for this module. Reviewed-by: Mark Chappell <None>
Closed
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add support for Boto3.create_launch_template_version's source_version parameter.
Accepted values:
ISSUE TYPE
COMPONENT NAME
ec2_launch_template.py
ADDITIONAL INFORMATION
Sanity tests passed for this module.