Add tag query to lambda_info module #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jillr @pjodouin @s-hertel @tremble @wimnat |
ansibullbot
added
bug
tremble
requested changes
Mar 16, 2021
There was a problem hiding this comment.
Hi @ngoduykhanh
Thanks for taking the time to raise this PR. I apologise for the delay in getting this reviewed.
A few things:
- Rather than adding the
max_itemsandnext_markerparameters it's generally better to use the boto3 paginators (see https://github.com/ansible-collections/community.aws/pull/442/files for an example) - Please add a changelog fragment: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
- Please update the integration tests to include some examples of setting/fetching tags (tests/integration/targets/lambda/tasks/main.yml)
There's also no need to update docs/community.aws.lambda_info_module.rst this will get updated automatically when we push the next release.
ansibullbot
added
needs_revision
|
I've rebased this PR and added a changelog and minimal integration test. Only thing blocking this PR is some permissions in CI |
tremble
approved these changes
Oct 24, 2021
ansibullbot
added
community_review
integration
jillr
approved these changes
Oct 26, 2021
|
recheck |
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…s#598) ec2_vpc_subnet: Add support for OutpostArn param SUMMARY Added support for OutpostArn param in ec2_vpc_subnet. Fixes ansible-collections#375 . ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_subnet Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Add tag query to lambda_info module SUMMARY This PR to add tags query into the lambda_info module. It is helpful to be able to query the Lambda function's tag list so we can integrate future actions. This PR also fix some missing parameter ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME lambda_info ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@5235a3b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR to add tags query into the
lambda_infomodule. It is helpful to be able to query the Lambda function's tag list so we can integrate future actions.This PR also fix some missing parameter
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION