Fix queue attribute comparison #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
|
Seems like one of the checks is stuck. Not sure how to trigger it... |
|
Don't worry about the "gate" check, this one will run once the PR has been reviewed and approved for merging (it's a final check that's run to make sure that the tests still pass before automatically merging the PR) |
tremble
approved these changes
Jul 9, 2021
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 15, 2021
…eueIdempotent Fix queue attribute comparison SUMMARY Fixes sqs queue attribute comparison so updates are not performed on subsequent runs. Also adds integration tests to verify this behavior. Fixes ansible-collections#578 ISSUE TYPE Bugfix Pull Request COMPONENT NAME sqs_queue ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@3513a09
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…eueIdempotent Fix queue attribute comparison SUMMARY Fixes sqs queue attribute comparison so updates are not performed on subsequent runs. Also adds integration tests to verify this behavior. Fixes ansible-collections#578 ISSUE TYPE Bugfix Pull Request COMPONENT NAME sqs_queue ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@3513a09
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 17, 2021
…eueIdempotent Fix queue attribute comparison SUMMARY Fixes sqs queue attribute comparison so updates are not performed on subsequent runs. Also adds integration tests to verify this behavior. Fixes ansible-collections#578 ISSUE TYPE Bugfix Pull Request COMPONENT NAME sqs_queue ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@36b1d6f
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
Fix queue attribute comparison SUMMARY Fixes sqs queue attribute comparison so updates are not performed on subsequent runs. Also adds integration tests to verify this behavior. Fixes ansible-collections#578 ISSUE TYPE Bugfix Pull Request COMPONENT NAME sqs_queue ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Chappell <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
Fix queue attribute comparison SUMMARY Fixes sqs queue attribute comparison so updates are not performed on subsequent runs. Also adds integration tests to verify this behavior. Fixes ansible-collections#578 ISSUE TYPE Bugfix Pull Request COMPONENT NAME sqs_queue ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Chappell <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
Fix queue attribute comparison SUMMARY Fixes sqs queue attribute comparison so updates are not performed on subsequent runs. Also adds integration tests to verify this behavior. Fixes ansible-collections#578 ISSUE TYPE Bugfix Pull Request COMPONENT NAME sqs_queue ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Chappell <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…ity_group_names (ansible-collections#592) elb_classic_lb: fix - resolve security_group_ids when providing security_group_names SUMMARY Fix failed to resolve security_group_ids when providing security_group_names. Fix broken tasks in integration tests. Fixes ansible-collections#589. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes sqs queue attribute comparison so updates are not performed on subsequent runs. Also adds integration tests to verify this behavior.
Fixes #578
ISSUE TYPE
COMPONENT NAME
sqs_queue
ADDITIONAL INFORMATION