fix: typo for verifying environmentFiles #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
There was a problem hiding this comment.
@vikalpj Thank you for working on this. Could you please include a changelog fragment https://docs.ansible.com/ansible/latest/dev_guide/testing/sanity/changelog.html?
|
@alinabuzachis done :) |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 15, 2021
…ch-1 fix: typo for verifying environmentFiles SUMMARY Validation for environmentFiles is incorrect. We need to validate the type key of the code but we are actually validating the value key. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@9b62c23
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…ch-1 fix: typo for verifying environmentFiles SUMMARY Validation for environmentFiles is incorrect. We need to validate the type key of the code but we are actually validating the value key. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@9b62c23
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 17, 2021
…ch-1 fix: typo for verifying environmentFiles SUMMARY Validation for environmentFiles is incorrect. We need to validate the type key of the code but we are actually validating the value key. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@d6a4330
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
fix: typo for verifying environmentFiles SUMMARY Validation for environmentFiles is incorrect. We need to validate the type key of the code but we are actually validating the value key. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
fix: typo for verifying environmentFiles SUMMARY Validation for environmentFiles is incorrect. We need to validate the type key of the code but we are actually validating the value key. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
fix: typo for verifying environmentFiles SUMMARY Validation for environmentFiles is incorrect. We need to validate the type key of the code but we are actually validating the value key. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Validation for
environmentFilesis incorrect. We need to validate the type key of the code but we are actually validating the value key.ISSUE TYPE
COMPONENT NAME
ecs_taskdefinition.py
ADDITIONAL INFORMATION