test: aws_msk_cluster is slow #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aws_msk_cluster test takes a bit of time. Let's be sure this does not become a problem in the future by isolating it on its own dedicated job.
|
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
integration
|
recheck |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 15, 2021
…-aws_msk_cluster-is-slow_26143 test: aws_msk_cluster is slow The aws_msk_cluster test takes a bit of time. Let's be sure this does not become a problem in the future by isolating it on its own dedicated job. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4956f97
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…-aws_msk_cluster-is-slow_26143 test: aws_msk_cluster is slow The aws_msk_cluster test takes a bit of time. Let's be sure this does not become a problem in the future by isolating it on its own dedicated job. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4956f97
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 17, 2021
…-aws_msk_cluster-is-slow_26143 test: aws_msk_cluster is slow The aws_msk_cluster test takes a bit of time. Let's be sure this does not become a problem in the future by isolating it on its own dedicated job. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@74a5aa7
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…luster-is-slow_26143 test: aws_msk_cluster is slow The aws_msk_cluster test takes a bit of time. Let's be sure this does not become a problem in the future by isolating it on its own dedicated job.
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…luster-is-slow_26143 test: aws_msk_cluster is slow The aws_msk_cluster test takes a bit of time. Let's be sure this does not become a problem in the future by isolating it on its own dedicated job.
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…luster-is-slow_26143 test: aws_msk_cluster is slow The aws_msk_cluster test takes a bit of time. Let's be sure this does not become a problem in the future by isolating it on its own dedicated job.
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…e-collections#646) Handle ResourceNotFoundException while iterating certificates SUMMARY The module/utils/acm.py was not correctly handling deletion of certificates. While iterating over a list of certificates, the get_certificate function was making API calls to obtain more information about the certificates, but some certificates may be deleted while iterating. Fixes ansible-collections#622 ISSUE TYPE Bugfix Pull Request COMPONENT NAME acm.py ADDITIONAL INFORMATION Wow, it seems many tests are very flaky. I'm attempting to fix an issue in ACM, but problems occur elsewhere. Not to mention I raised this PR to fix ansible-collections#622, which was discovered while working on ansible-collections#870. And I discovered other issues as well, and so it looks like it's not possible to make any progress without going down a tree of bug fixes. TypeError: 'NoneType' object is not subscriptable fatal: [testhost]: FAILED! => { "changed": false, "module_stderr": "Traceback (most recent call last):\n File \"<stdin>\", line 121, in <module>\n File \"<stdin>\", line 113, in _ansiballz_main\n File \"<stdin>\", line 61, in invoke_module\n File \"/usr/lib64/python3.8/runpy.py\", line 207, in run_module\n return _run_module_code(code, init_globals, run_name, mod_spec)\n File \"/usr/lib64/python3.8/runpy.py\", line 97, in _run_module_code\n _run_code(code, mod_globals, init_globals,\n File \"/usr/lib64/python3.8/runpy.py\", line 87, in _run_code\n exec(code, run_globals)\n File \"/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 248, in <module>\n File \"/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 242, in main\n File \"/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 132, in process\n File \"/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 220, in ensure_igw_present\n File \"/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 158, in get_igw_info\nTypeError: 'NoneType' object is not subscriptable\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1 } Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aws_msk_cluster test takes a bit of time. Let's be sure this does
not become a problem in the future by isolating it on its own
dedicated job.