Migrate elasticache_subnet_group to boto3 #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
tremble
force-pushed
the
boto3/elasticache_subnet_group
branch
from
9f4518d
to
e6804ce
Compare
ansibullbot
added
integration
|
|
||
| def get_subnet_group(name): | ||
| try: | ||
| groups = client.describe_cache_subnet_groups( |
There was a problem hiding this comment.
Why not using the paginator instead https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elasticache.html#ElastiCache.Paginator.DescribeCacheSubnetGroups?
There was a problem hiding this comment.
It's doing a search by name, there should be only the one response, so there shouldn't be a need to paginate. Paginators need to be separately wrapped with AWSRetry.
alinabuzachis
approved these changes
Sep 20, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
marknet15
added a commit
to marknet15/community.aws
that referenced
this pull request
Oct 8, 2021
commit 11ac443 Merge: c16440c 19e60c2 Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Fri Oct 1 05:49:58 2021 -0700 Merge pull request ansible-collections#739 from tremble/sns_topic/httpretry_strings sns_topic - Define shape for delivery_policy. SUMMARY delivery_policy was previously defined just as "dict", this meant that if someone passed in JSON or quoted the numbers, AWS would spit errors at them. By defining the shape of delivery_policy Ansible will automatically convert "10" to 10, as well as providing cleaner error messages for missing components of the policy. ISSUE TYPE Bugfix Pull Request COMPONENT NAME sns_topic ADDITIONAL INFORMATION obsoletes ansible-collections#716 Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> commit c16440c Merge: d35601e f8fb040 Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Fri Oct 1 11:57:13 2021 +0000 Merge pull request ansible-collections#740 from tremble/tests/config Add tests config file to specificaly state that we're not interested in python < 3.6 SUMMARY With Ansible 2.12 ansible-test supports explicitly defining the python version supported by a collection ISSUE TYPE Feature Pull Request COMPONENT NAME sanity tests ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> commit 19e60c2 Author: Mark Chappell <mchappel@redhat.com> Date: Fri Oct 1 13:20:57 2021 +0200 changelog commit f8fb040 Author: Mark Chappell <mchappel@redhat.com> Date: Thu Sep 30 14:44:50 2021 +0200 Add tests config file to specificaly state that we're not interested in python < 3.6 commit d35601e Merge: 4babc11 f052df6 Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Thu Sep 30 11:31:31 2021 +0000 Merge pull request ansible-collections#735 from tremble/iam_cert/files Deprecate passing file names to the iam_server_certificate module SUMMARY iam_server_certificate currently accepts file names (or content) in the cert, chain_cert and key options. Since the module directly uses open(). This will perform a 'remote' lookup with unexpected results for relative file paths. Encourage the use of lookups so that the behaviour will at least be predictable. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> commit 99238d1 Author: Mark Chappell <mchappel@redhat.com> Date: Thu Sep 30 12:01:21 2021 +0200 sns_topic - Define shape for delivery_policy. commit 8d639c6 Author: Mark Chappell <mchappel@redhat.com> Date: Thu Sep 30 08:59:44 2021 +0200 Add integration test commit 4babc11 Merge: 3fbca8f fb38343 Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Wed Sep 29 20:03:08 2021 +0000 Merge pull request ansible-collections#595 from kbrebanov/fix-route53-identifier route53: Identifier missing from resource_record_set. SUMMARY Currently, the identifier parameter is never included in resource_record_set. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION The identifier parameter is always nullified as it's not included in resource_record_set. This change allows the identifier to be included and scrubbed if None. Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> commit fb38343 Author: Mark Chappell <mchappel@redhat.com> Date: Wed Sep 29 20:33:10 2021 +0200 Add integration tests commit 83dd7ba Author: Kevin Brebanov <kbrebanov@users.noreply.github.com> Date: Thu Sep 16 16:00:06 2021 -0400 Add changelog fragment for pull request ansible-collections#595 commit e038cb3 Author: Kevin Brebanov <kbrebanov@users.noreply.github.com> Date: Mon Jun 7 10:41:05 2021 -0400 route53: Prevent identifier from always being scrubbed. commit f052df6 Author: Mark Chappell <mchappel@redhat.com> Date: Mon Sep 27 09:44:38 2021 +0200 changelog commit cd42d43 Author: Mark Chappell <mchappel@redhat.com> Date: Mon Sep 27 09:26:23 2021 +0200 Deprecate passing file names to the iam_server_certificate module commit 3fbca8f Merge: 0769e8e dddd547 Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Tue Sep 28 12:48:14 2021 +0000 Merge pull request ansible-collections#738 from Andersson007/test_1 Copy ignore-2.12.txt to ignore-2.13.txt SUMMARY Relates to ansible-collections/overview#45 (comment) Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> commit dddd547 Author: Andrew Klychkov <aklychko@redhat.com> Date: Tue Sep 28 13:44:04 2021 +0200 Copy ignore-2.12.txt to ignore-2.13.txt commit 0769e8e Merge: 4c6f54b 395b77a Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Fri Sep 24 18:19:57 2021 +0000 Merge pull request ansible-collections#670 from alinabuzachis/elb_target_group/preserve_client_ip_enabled elb_target_group - add preserve_client_ip_enabled and proxy_protocol_v2_enabled options SUMMARY elb_target_group - add preserve_client_ip_enabled and proxy_protocol_v2_enabled options Fixes ansible-collections#555 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group.py Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> commit 4c6f54b Merge: 85dffb3 4f44d69 Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Fri Sep 24 13:38:10 2021 +0000 Merge pull request ansible-collections#702 from doticatto/patch-1 Undocumented IOPS return IOPS is being returned by the module, but simply was not documented. Simply a documentation change. ISSUE TYPE Docs Pull Request Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: None <None> commit 85dffb3 Merge: a55b7a9 59deefe Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Fri Sep 24 13:09:36 2021 +0000 Merge pull request ansible-collections#707 from boutetnico/add-cf-ssl-version cloudfront_distribution: add new security policy version TLSv1.2_2021 SUMMARY Add new TLSv1.2_2021 security policy for CloudFront viewer connections. ISSUE TYPE Feature Pull Request COMPONENT NAME cloudfront_distribution ADDITIONAL INFORMATION https://aws.amazon.com/about-aws/whats-new/2021/06/amazon-cloudfront-announces-new-tlsv12_2021-security-policy-for-viewer-connections/ Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: None <None> commit 395b77a Author: Mark Chappell <mchappel@redhat.com> Date: Fri Sep 24 14:49:59 2021 +0200 bump version added - missed the 2.0.0 release commit 5d0b57e Author: Alina Buzachis <abuzachis@redhat.com> Date: Tue Jul 20 16:03:48 2021 +0200 elb_target - add preserve_client_ip_enabled ond proxy_protocol_v2_enabled ptions Signed-off-by: Alina Buzachis <abuzachis@redhat.com> commit a55b7a9 Merge: 0954679 093aa24 Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Fri Sep 24 12:22:23 2021 +0000 Merge pull request ansible-collections#731 from tremble/eip_unbound Fix EIP allocation with in_vpc not set SUMMARY Our integration tests were setting in_vpc (because most use-cases need it) so we missed that setting the minimum possible configuration for an EIP resulted in an exception: ec2_eip: state: present in_vpc: '{{ omit }}' task path: /root/ansible_collections/community/aws/tests/output/.tmp/integration/ec2_eip-hkuj00lj-ÅÑŚÌβŁÈ/tests/integration/targets/ec2_eip/tasks/main.yml:666 <testhost> ESTABLISH LOCAL CONNECTION FOR USER: root <testhost> EXEC /bin/sh -c 'echo ~root && sleep 0' <testhost> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /root/.ansible/tmp `"&& mkdir "` echo /root/.ansible/tmp/ansible-tmp-1632477941.356962-3535-26932306567289 `" && echo ansible-tmp-1632477941.356962-3535-26932306567289="` echo /root/.ansible/tmp/ansible-tmp-1632477941.356962-3535-26932306567289 `" ) && sleep 0' Using module file /root/ansible_collections/community/aws/plugins/modules/ec2_eip.py <testhost> PUT /root/.ansible/tmp/ansible-local-1077my3ghuvo/tmp0lqxcnwq TO /root/.ansible/tmp/ansible-tmp-1632477941.356962-3535-26932306567289/AnsiballZ_ec2_eip.py <testhost> EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-tmp-1632477941.356962-3535-26932306567289/ /root/.ansible/tmp/ansible-tmp-1632477941.356962-3535-26932306567289/AnsiballZ_ec2_eip.py && sleep 0' <testhost> EXEC /bin/sh -c 'ANSIBLE_DEBUG_BOTOCORE_LOGS=True /usr/bin/python3.9 /root/.ansible/tmp/ansible-tmp-1632477941.356962-3535-26932306567289/AnsiballZ_ec2_eip.py && sleep 0' <testhost> EXEC /bin/sh -c 'rm -f -r /root/.ansible/tmp/ansible-tmp-1632477941.356962-3535-26932306567289/ > /dev/null 2>&1 && sleep 0' The full traceback is: Traceback (most recent call last): File "/tmp/ansible_ec2_eip_payload_rqxrzx_j/ansible_ec2_eip_payload.zip/ansible_collections/community/aws/plugins/modules/ec2_eip.py", line 376, in allocate_address File "/tmp/ansible_ec2_eip_payload_rqxrzx_j/ansible_ec2_eip_payload.zip/ansible_collections/amazon/aws/plugins/module_utils/core.py", line 334, in deciding_wrapper return retrying_wrapper(*args, **kwargs) File "/tmp/ansible_ec2_eip_payload_rqxrzx_j/ansible_ec2_eip_payload.zip/ansible_collections/amazon/aws/plugins/module_utils/cloud.py", line 118, in _retry_wrapper return _retry_func( File "/tmp/ansible_ec2_eip_payload_rqxrzx_j/ansible_ec2_eip_payload.zip/ansible_collections/amazon/aws/plugins/module_utils/cloud.py", line 68, in _retry_func return func() File "/usr/local/lib/python3.9/dist-packages/botocore/client.py", line 337, in _api_call return self._make_api_call(operation_name, kwargs) File "/usr/local/lib/python3.9/dist-packages/botocore/client.py", line 628, in _make_api_call request_dict = self._convert_to_request_dict( File "/usr/local/lib/python3.9/dist-packages/botocore/client.py", line 676, in _convert_to_request_dict request_dict = self._serializer.serialize_to_request( File "/usr/local/lib/python3.9/dist-packages/botocore/validate.py", line 297, in serialize_to_request raise ParamValidationError(report=report.generate_report()) botocore.exceptions.ParamValidationError: Parameter validation failed: Invalid type for parameter Domain, value: None, type: <class 'NoneType'>, valid types: <class 'str'> fatal: [testhost]: FAILED! => { "boto3_version": "1.15.0", "botocore_version": "1.18.0", "changed": false, "invocation": { "module_args": { "allow_reassociation": false, "aws_access_key": "AKIAQAEICK57ETHUOKNO", "aws_ca_bundle": null, "aws_config": null, "aws_secret_key": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "debug_botocore_endpoint_logs": true, "device_id": null, "ec2_url": null, "in_vpc": false, "private_ip_address": null, "profile": null, "public_ip": null, "public_ipv4_pool": null, "region": "us-east-1", "release_on_disassociation": false, "reuse_existing_ip_allowed": false, "security_token": null, "state": "present", "tag_name": null, "tag_value": null, "validate_certs": true, "wait_timeout": null } }, "msg": "Couldn't allocate Elastic IP address: Parameter validation failed:\nInvalid type for parameter Domain, value: None, type: <class 'NoneType'>, valid types: <class 'str'>", "resource_actions": [] } ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_eip ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> commit 093aa24 Author: Mark Chappell <mchappel@redhat.com> Date: Fri Sep 24 13:22:30 2021 +0200 Update changelogs/fragments/731-ec2_eip-not_in_vpc.yml commit e018cae Author: Mark Chappell <mchappel@redhat.com> Date: Fri Sep 24 12:15:11 2021 +0200 Changelog commit 0091444 Author: Mark Chappell <mchappel@redhat.com> Date: Fri Sep 24 12:10:08 2021 +0200 Fix bug when allocating an EIP with in_vpc not set commit 78fc2db Author: Mark Chappell <mchappel@redhat.com> Date: Fri Sep 24 12:06:51 2021 +0200 Add integration test commit 0954679 Merge: f9654cf df28789 Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Thu Sep 23 10:51:48 2021 +0000 Merge pull request ansible-collections#728 from tremble/rename/iam_cert Rename iam_cert to iam_server_certificate for consistency SUMMARY iam_cert (and what used to be known as iam_cert_facts) only deal with "server" certificates (AWS also has a CA cert offering in IAM) with the big 2.9 _fact rename iam_cert_facts was renamed to iam_server_certificate_info. (more tests and a migration to boto3 to follow) ISSUE TYPE Feature Pull Request COMPONENT NAME iam_cert ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> commit df28789 Author: Mark Chappell <mchappel@redhat.com> Date: Thu Sep 23 10:46:27 2021 +0200 Rename iam_cert to iam_server_certificate for consistency commit f9654cf Merge: ee984b2 861c966 Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Thu Sep 23 08:54:50 2021 +0000 Merge pull request ansible-collections#724 from tremble/boto3/redshift_subnet_group Migrate redshift_subnet_group to boto3 SUMMARY Migrate redshift_subnet_group to boto3 note: while there additional features (tagging springs to mind) that could be added, I'm trying to avoid scope creep and mostly just want to knock out migrations of the remaining old-boto modules. That said, I am converting tags using the boto3_tag_list_to_ansible_dict helper, in the return values this is just to avoid needing to change formats in future ISSUE TYPE Feature Pull Request COMPONENT NAME redshift_subnet_group ADDITIONAL INFORMATION Depends-On: ansible-collections#719 Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> commit 861c966 Author: Mark Chappell <mchappel@redhat.com> Date: Thu Sep 23 09:10:45 2021 +0200 changelog commit 451bef7 Author: Mark Chappell <mchappel@redhat.com> Date: Sat Sep 18 10:13:55 2021 +0200 Add documentation and support for check_mode commit aac8190 Author: Mark Chappell <mchappel@redhat.com> Date: Sat Sep 18 09:59:28 2021 +0200 Add additional tests and documentation around new return values commit dc4cd6e Author: Mark Chappell <mchappel@redhat.com> Date: Sat Sep 18 09:12:11 2021 +0200 Add additional tests for minimal/partial parameters. commit c21eac8 Author: Mark Chappell <mchappel@redhat.com> Date: Fri Sep 17 23:56:02 2021 +0200 Migrate redshift_subnet_group to boto3 commit ee984b2 Merge: 0ed628a 402b472 Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Thu Sep 23 00:06:44 2021 +0000 Merge pull request ansible-collections#715 from jillr/2_0_0_prep Prepare 2.0.0 release SUMMARY Prepare 2.0.0 release. Run add_docs, generate changelog, update versions ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: None <None> commit 402b472 Author: jillr <jillr@redhat.com> Date: Tue Sep 21 18:44:50 2021 +0000 refresh docs commit 398badf Author: jillr <jillr@redhat.com> Date: Thu Sep 16 17:54:21 2021 +0000 refresh fragments and docs commit 49b2618 Author: jillr <jillr@redhat.com> Date: Wed Sep 15 21:46:41 2021 +0000 Prepare 2.0.0 release commit 0ed628a Merge: 7672e7d 7c7b028 Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Wed Sep 22 16:01:49 2021 +0000 Merge pull request ansible-collections#719 from tremble/tests/redshift_subnet_group Add integration tests for redshift_subnet_group SUMMARY Add integration tests for redshift_subnet_group CI / IAM Permissions ISSUE TYPE Feature Pull Request COMPONENT NAME redshift_subnet_group ADDITIONAL INFORMATION Reviewed-by: None <None> commit 7672e7d Merge: 2defed0 d779a7b Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Mon Sep 20 15:11:18 2021 +0000 Merge pull request ansible-collections#723 from tremble/boto3/elasticache_subnet_group Migrate elasticache_subnet_group to boto3 SUMMARY Migrate elasticache_subnet_group to boto3 note: while there additional features (tagging springs to mind) that could be added, I'm trying to avoid scope creep and mostly just want to knock out migrations of the remaining old-boto modules. ISSUE TYPE Feature Pull Request COMPONENT NAME elasticache_subnet_group ADDITIONAL INFORMATION Depends-On: ansible-collections#720 Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> commit 2defed0 Merge: e125e89 002b237 Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Mon Sep 20 09:28:58 2021 +0000 Merge pull request ansible-collections#725 from tremble/tests/dynamodb_table Integration tests for dynamodb SUMMARY Integration tests for dynamodb There's a lot of commented out tests, the current module's really inconsistent about return values and the "defaults" result in various settings being reset. The current module also handles a number of temporary failures poorly (hence a lot of retry/until in the tests). ISSUE TYPE Feature Pull Request COMPONENT NAME dynamodb ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> commit 002b237 Author: Mark Chappell <mchappel@redhat.com> Date: Sat Sep 18 21:10:40 2021 +0200 Integration tests for dynamodb commit d779a7b Author: Mark Chappell <mchappel@redhat.com> Date: Sat Sep 18 08:36:41 2021 +0200 Test creation with no description provided commit 8db0ada Author: Mark Chappell <mchappel@redhat.com> Date: Sat Sep 18 08:35:38 2021 +0200 Fail cleanly if no subnets are provided on creation. commit e6804ce Author: Mark Chappell <mchappel@redhat.com> Date: Fri Sep 17 20:48:03 2021 +0200 Add support for check_mode commit 24c8211 Author: Mark Chappell <mchappel@redhat.com> Date: Fri Sep 17 22:06:13 2021 +0200 Add documentation and tests for return values commit 3cb67e4 Author: Mark Chappell <mchappel@redhat.com> Date: Fri Sep 17 20:38:34 2021 +0200 Migrate elasticache_subnet_group to boto3 commit e125e89 Merge: 095d4e4 7e14f92 Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Fri Sep 17 19:46:15 2021 +0000 Merge pull request ansible-collections#720 from tremble/tests/elasticache_subnet_group Split elasticache_subnet_group integration tests out SUMMARY In preparation for rewriting elasticache_subnet_group using boto3 split out the integration tests and exercise it slightly more. ISSUE TYPE Feature Pull Request COMPONENT NAME elasticache_subnet_group ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> commit 7e14f92 Author: Mark Chappell <mchappel@redhat.com> Date: Thu Sep 16 21:52:09 2021 +0200 Split elasticache_subnet_group out commit 7c7b028 Author: Mark Chappell <mchappel@redhat.com> Date: Thu Sep 16 18:03:30 2021 +0200 Add integration tests for redshift_subnet_group commit 095d4e4 Merge: 97972e0 0a9551d Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Thu Sep 16 15:50:14 2021 +0000 Merge pull request ansible-collections#644 from tremble/boto_versions Add constraints and requirements for unit/integration tests SUMMARY Now that we state that we support specific minimum versions of the AWS SDKs, make sure we base our unit/integration tests against them such that modules need to explicitly test/request newer versions of the SDKs. ISSUE TYPE Feature Pull Request COMPONENT NAME tests/integration tests/unit ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#461 see also: ansible/ansible-zuul-jobs#991 see also: ansible-collections/amazon.aws#404 Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> commit 97972e0 Merge: 8025686 0b5d1be Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Thu Sep 16 14:12:37 2021 +0000 Merge pull request ansible-collections#717 from tremble/tests/setup_roles Add setup_botocore_pip/ setup_ec2_facts/ setup_sshkey/ integration test helpers from amazon.aws SUMMARY Various components of the integration tests have been refactored to aid in consistency. Bring the helper modules over from amazon.aws ISSUE TYPE Feature Pull Request COMPONENT NAME tests/integration ADDITIONAL INFORMATION Original PRs (https://github.com/ansible-collections/amazon.aws/pull/): 427 485 481 498 Reviewed-by: None <None> commit 0a9551d Author: Mark Chappell <mchappel@redhat.com> Date: Fri Jul 16 15:47:40 2021 +0200 Add constraints and requirements for unit/integration tests consistent with the minimum versions of the AWS SDK we explicitly state we support commit 0b5d1be Author: Mark Chappell <mchappel@redhat.com> Date: Thu Sep 16 12:07:38 2021 +0200 Add setup_botocore_pip/ setup_ec2_facts/ setup_sshkey/ integration test helpers from amazon.aws commit 8025686 Merge: 19cc031 f5d98ba Author: ansible-zuul[bot] <48994755+ansible-zuul[bot]@users.noreply.github.com> Date: Thu Sep 16 06:22:34 2021 +0000 Merge pull request ansible-collections#711 from tremble/botocore/1.18.0 Bump botocore/boto3 requirements prior to release of 2.0.0 SUMMARY Follow up to ansible-collections/amazon.aws#502 We've bumped our minimum requirements in anticipation of release 2.0.0 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> commit f5d98ba Author: Mark Chappell <mchappel@redhat.com> Date: Wed Sep 15 06:44:54 2021 +0200 Bump botocore/boto3 requirements prior to release of 2.0.0 commit 4f44d69 Author: John Mahoney <john.david.mahoney@gmail.com> Date: Tue Sep 14 16:23:03 2021 -0400 Removed rst changes b/c autogenerated commit 59deefe Author: Nicolas Boutet <amd3002@gmail.com> Date: Thu Sep 9 10:30:04 2021 +0200 Add changelog fragment commit 9156837 Author: Nicolas Boutet <amd3002@gmail.com> Date: Thu Sep 9 10:23:56 2021 +0200 cloudfront_distribution: add new cipher version TLSv1.2_2021 commit fea75df Author: John Mahoney <john.david.mahoney@gmail.com> Date: Thu Sep 2 16:30:12 2021 -0400 Update community.aws.rds_instance_info_module.rst commit 64fc073 Author: John Mahoney <john.david.mahoney@gmail.com> Date: Thu Sep 2 16:11:50 2021 -0400 Undocumented IOPS return IOPS is being returned by the module, but simply was not documented.
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…ections#723) parse_aws_arn should accept services with - in the name SUMMARY parse_aws_arn currently uses \w for service names, there are a couple of services with - in the name, which is not included by \w ([a-zA-Z0-9_]) ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/module_utils/arn.py ADDITIONAL INFORMATION Includes net-new unit tests. Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Migrate elasticache_subnet_group to boto3
note: while there additional features (tagging springs to mind) that could be added, I'm trying to avoid scope creep and mostly just want to knock out migrations of the remaining old-boto modules.
ISSUE TYPE
COMPONENT NAME
elasticache_subnet_group
ADDITIONAL INFORMATION
Depends-On: #720