Fix EIP allocation with in_vpc not set

changelogs/fragments/731-ec2_eip-not_in_vpc.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- ec2_eip - fix bug when allocating an EIP but not associating it to a VPC (https://github.com/ansible-collections/community.aws/pull/731).

plugins/modules/ec2_eip.py

@@ -344,10 +344,11 @@ def address_is_associated_with_device(ec2, module, address, device_id, is_instan
 
 def allocate_address(ec2, module, domain, reuse_existing_ip_allowed, check_mode, tag_dict=None, public_ipv4_pool=None):
     """ Allocate a new elastic IP address (when needed) and return it """
+    if not domain:
+        domain = 'standard'
+
     if reuse_existing_ip_allowed:
         filters = []
-        if not domain:
-            domain = 'standard'
         filters.append({'Name': 'domain', "Values": [domain]})
 
         if tag_dict is not None:

tests/integration/targets/ec2_eip/tasks/main.yml

@@ -662,6 +662,25 @@
       state: absent
       name: '{{ resource_prefix }}-vpc'
       cidr_block: '{{ vpc_cidr }}'
+
+  - name: Create an EIP outside a VPC
+    ec2_eip:
+      state: present
+      in_vpc: '{{ omit }}'
+    register: unbound_eip
+  - assert:
+      that:
+      - unbound_eip is successful
+      - unbound_eip is changed
+  - name: Release EIP
+    ec2_eip:
+      state: absent
+      public_ip: '{{ unbound_eip.public_ip }}'
+    register: release_unbound_eip
+  - assert:
+      that:
+      - release_unbound_eip is successful
+      - release_unbound_eip is changed
   # =====================================================
   always:
   - name: Cleanup instance (by id)
@@ -735,6 +754,12 @@
       public_ip: '{{ no_tagged_eip.public_ip }}'
     when: no_tagged_eip is changed
     ignore_errors: true
+  - name: Cleanup unbound_eip
+    ec2_eip:
+      state: absent
+      public_ip: '{{ unbound_eip.public_ip }}'
+    when: unbound_eip is changed
+    ignore_errors: true
   - name: Cleanup VPC
     ec2_vpc_net:
       state: absent