Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iam_server_certificate - Migrate to boto3 #737

Merged
merged 4 commits into from
Oct 14, 2021
Merged

iam_server_certificate - Migrate to boto3 #737

merged 4 commits into from
Oct 14, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 27, 2021 •
edited by goneri
Loading

SUMMARY

Migrate iam_server_certificate to boto3

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iam_server_certificate

@ansibullbot
Copy link

cc @defionscode @jillr @markuman @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Sep 27, 2021
@ansibullbot ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Oct 8, 2021
@tremble tremble removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Oct 8, 2021
alinabuzachis
alinabuzachis approved these changes Oct 12, 2021
View reviewed changes
plugins/modules/iam_server_certificate.py Outdated Show resolved Hide resolved
@tremble tremble added gate and removed gate labels Oct 12, 2021
@goneri goneri added gate and removed gate labels Oct 12, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goneri
Copy link
Member

goneri commented Oct 12, 2021

It looks like the problem was the Depends-On pointing on a repository that Zuul does not know about.

@ansible-zuul ansible-zuul bot removed the gate label Oct 12, 2021
@tremble tremble added the gate label Oct 14, 2021
@ansible-zuul ansible-zuul bot merged commit 2d9ddb6 into ansible-collections:main Oct 14, 2021
@tremble tremble linked an issue Oct 16, 2021 that may be closed by this pull request
community.aws.iam_cert throws invalid security token error even when other aws modules successfully use my aws boto profile #469
Closed
@tremble tremble mentioned this pull request Oct 16, 2021
Closed
@tremble tremble deleted the boto3/iam_cert branch November 26, 2021 12:44
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@alinabuzachis
remove comment it seems to not be picked up in the CI (ansible-collec…
7297e31 
…tions#737)

Remove comment from the legacy_missing_tests suite

SUMMARY

Remove comment from the legacy_missing_tests suite. The comment doesn't allow the splitter to match aws_ssm.

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@markuman markuman Awaiting requested review from markuman

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
4 participants
@tremble @ansibullbot @goneri @alinabuzachis