Fix cloudfront_distribution s3_origin_access_identity_enabled bug #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
|
recheck |
|
Build succeeded.
|
marknet15
force-pushed
the
cloudfront-bug
branch
from
bb2f3a1
to
34a914e
Compare
ansibullbot
added
bug
|
Build succeeded.
|
markuman
approved these changes
Jan 29, 2022
markuman
added
backport-2
alinabuzachis
approved these changes
Jan 31, 2022
|
Build succeeded (gate pipeline).
|
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #910 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 31, 2022
Fix cloudfront_distribution s3_origin_access_identity_enabled bug SUMMARY If s3_origin_access_identity_enabled is set to True but no s3_origin_config then a default origin config is applied however it also picks up s3_origin_access_identity_enabled as S3OriginAccessIdentityEnabled and passes it to the API request which is not a valid option to be passed and then fails validation. Fixes: #749 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution ADDITIONAL INFORMATION The option mention is not valid for the API request: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudfront.html#CloudFront.Client.create_distribution Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> (cherry picked from commit cecc9e8)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #911 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 31, 2022
Fix cloudfront_distribution s3_origin_access_identity_enabled bug SUMMARY If s3_origin_access_identity_enabled is set to True but no s3_origin_config then a default origin config is applied however it also picks up s3_origin_access_identity_enabled as S3OriginAccessIdentityEnabled and passes it to the API request which is not a valid option to be passed and then fails validation. Fixes: #749 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution ADDITIONAL INFORMATION The option mention is not valid for the API request: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudfront.html#CloudFront.Client.create_distribution Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> (cherry picked from commit cecc9e8)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 31, 2022
…) (#911) [PR #881/cecc9e80 backport][stable-3] Fix cloudfront_distribution s3_origin_access_identity_enabled bug This is a backport of PR #881 as merged into main (cecc9e8). SUMMARY If s3_origin_access_identity_enabled is set to True but no s3_origin_config then a default origin config is applied however it also picks up s3_origin_access_identity_enabled as S3OriginAccessIdentityEnabled and passes it to the API request which is not a valid option to be passed and then fails validation. Fixes: #749 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution ADDITIONAL INFORMATION The option mention is not valid for the API request: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudfront.html#CloudFront.Client.create_distribution
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
…) (#910) [PR #881/cecc9e80 backport][stable-2] Fix cloudfront_distribution s3_origin_access_identity_enabled bug This is a backport of PR #881 as merged into main (cecc9e8). SUMMARY If s3_origin_access_identity_enabled is set to True but no s3_origin_config then a default origin config is applied however it also picks up s3_origin_access_identity_enabled as S3OriginAccessIdentityEnabled and passes it to the API request which is not a valid option to be passed and then fails validation. Fixes: #749 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution ADDITIONAL INFORMATION The option mention is not valid for the API request: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudfront.html#CloudFront.Client.create_distribution
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Module naming guidelines SUMMARY Originally discussed in ansible-collections#610 Here's an initial attempt at some module naming (and module scoping) guidelines. Assuming we adopt this, I recommend is that: we can do the renames as part of 5.0.0, but this isn't a must and wouldn't be considered a blocker to 5.0.0 unless otherwise agreed. any modules moving from community.aws to amazon.aws would be renamed if appropriate as part of the move. we do not specify a deprecation date at this time, but leave a comment in the redirect that any deprecation cycle should not start before 2024-09-01 (to avoid potential migration fatigue issues), ISSUE TYPE Docs Pull Request COMPONENT NAME docs/docsite/rst/dev_guidelines.rst ADDITIONAL INFORMATION fixes: ansible-collections#610 Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If
s3_origin_access_identity_enabledis set toTruebut nos3_origin_configthen a default origin config is applied however it also picks ups3_origin_access_identity_enabledasS3OriginAccessIdentityEnabledand passes it to the API request which is not a valid option to be passed and then fails validation.Fixes: #749
ISSUE TYPE
COMPONENT NAME
cloudfront_distribution
ADDITIONAL INFORMATION
The option mention is not valid for the API request:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudfront.html#CloudFront.Client.create_distribution