IAM Role Removal Does Not Require Removal of Permission Boundary #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n boundary before deleting the role
ansibullbot
added
bug
|
@phene Thanks for your PR. Can you also please add a bugfixes changelog fragment? |
markuman
added
backport-2
|
Changelog fragment added, @markuman |
markuman
approved these changes
Mar 15, 2022
tremble
approved these changes
Mar 16, 2022
changelogs/fragments/961-iam-role-should-not-remove-permission-boundary-before-deletion.yml
Outdated
Show resolved
Hide resolved
…-boundary-before-deletion.yml
|
I've run the integration tests 'locally', and everything still works. @phene Thanks for the PR, sorry it's taken a while to get it merged. |
|
regate |
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #999 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
IAM Role Removal Does Not Require Removal of Permission Boundary SUMMARY Removes unnecessary removal of permission boundary from a role when deleting a role. Unlike inline policies, permission boundaries do not need to be removed from an IAM role before deleting the IAM role. This behavior causes issues when a permission boundary is inherited that prevents removal of the permission boundary. Fixes #959 ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Chappell <None> (cherry picked from commit e670b34)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1000 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
IAM Role Removal Does Not Require Removal of Permission Boundary SUMMARY Removes unnecessary removal of permission boundary from a role when deleting a role. Unlike inline policies, permission boundaries do not need to be removed from an IAM role before deleting the IAM role. This behavior causes issues when a permission boundary is inherited that prevents removal of the permission boundary. Fixes #959 ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Chappell <None> (cherry picked from commit e670b34)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
… (#999) [PR #961/e670b348 backport][stable-2] IAM Role Removal Does Not Require Removal of Permission Boundary This is a backport of PR #961 as merged into main (e670b34). SUMMARY Removes unnecessary removal of permission boundary from a role when deleting a role. Unlike inline policies, permission boundaries do not need to be removed from an IAM role before deleting the IAM role. This behavior causes issues when a permission boundary is inherited that prevents removal of the permission boundary. Fixes #959 ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
… (#1000) [PR #961/e670b348 backport][stable-3] IAM Role Removal Does Not Require Removal of Permission Boundary This is a backport of PR #961 as merged into main (e670b34). SUMMARY Removes unnecessary removal of permission boundary from a role when deleting a role. Unlike inline policies, permission boundaries do not need to be removed from an IAM role before deleting the IAM role. This behavior causes issues when a permission boundary is inherited that prevents removal of the permission boundary. Fixes #959 ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Unit test cleanup SUMMARY Speaking to @mattclay, pytest based unit tests are generally considered preferred over unittest based unit tests. For the sake of having "good" examples in amazon.aws, migrates unittest based tests over to pytest Additionally: Moves tests about to reflect module_utils Cleans up the boto3/botocore test skipping uses "pytest.raises" rather than try/except blocks Cleans up unused variables Cleans up unused imports fixes s3_object unit test (was trying to import from the old location, redirects don't handle this) ISSUE TYPE Feature Pull Request COMPONENT NAME tests/units ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ible-collections#961) IAM Role Removal Does Not Require Removal of Permission Boundary SUMMARY Removes unnecessary removal of permission boundary from a role when deleting a role. Unlike inline policies, permission boundaries do not need to be removed from an IAM role before deleting the IAM role. This behavior causes issues when a permission boundary is inherited that prevents removal of the permission boundary. Fixes ansible-collections#959 ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@e670b34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removes unnecessary removal of permission boundary from a role when deleting a role. Unlike inline policies, permission boundaries do not need to be removed from an IAM role before deleting the IAM role. This behavior causes issues when a permission boundary is inherited that prevents removal of the permission boundary.
Fixes #959
ISSUE TYPE
COMPONENT NAME
iam_role