wafv2_web_acl: prevent exception when element is not a dict #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
alinabuzachis
approved these changes
Mar 4, 2022
markuman
added
backport-3
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #991 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
wafv2_web_acl: prevent exception when element is not a dict
SUMMARY
the geo_match_statement statement paremeter country_codes is a list and will fail the current implementation
File "/tmp/ansible_community.aws.wafv2_web_acl_payload_8xvwtxvw/ansible_community.aws.wafv2_web_acl_payload.zip/ansible_collections/community/aws/plugins/module_utils/wafv2.py", line 52, in wafv2_snake_dict_to_camel_dict
AttributeError: 'str' object has no attribute 'keys'
rules:
- name: block-germany
priority: 0
action:
block: {}
visibility_config:
sampled_requests_enabled: yes
cloud_watch_metrics_enabled: yes
metric_name: block-germany
statement:
geo_match_statement:
country_codes:
- DE
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
plugins/module_utils/wafv2.py
ADDITIONAL INFORMATION
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 9230c69)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #992 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
wafv2_web_acl: prevent exception when element is not a dict
SUMMARY
the geo_match_statement statement paremeter country_codes is a list and will fail the current implementation
File "/tmp/ansible_community.aws.wafv2_web_acl_payload_8xvwtxvw/ansible_community.aws.wafv2_web_acl_payload.zip/ansible_collections/community/aws/plugins/module_utils/wafv2.py", line 52, in wafv2_snake_dict_to_camel_dict
AttributeError: 'str' object has no attribute 'keys'
rules:
- name: block-germany
priority: 0
action:
block: {}
visibility_config:
sampled_requests_enabled: yes
cloud_watch_metrics_enabled: yes
metric_name: block-germany
statement:
geo_match_statement:
country_codes:
- DE
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
plugins/module_utils/wafv2.py
ADDITIONAL INFORMATION
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 9230c69)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
) [PR #962/9230c698 backport][stable-3] wafv2_web_acl: prevent exception when element is not a dict This is a backport of PR #962 as merged into main (9230c69). SUMMARY the geo_match_statement statement paremeter country_codes is a list and will fail the current implementation File "/tmp/ansible_community.aws.wafv2_web_acl_payload_8xvwtxvw/ansible_community.aws.wafv2_web_acl_payload.zip/ansible_collections/community/aws/plugins/module_utils/wafv2.py", line 52, in wafv2_snake_dict_to_camel_dict AttributeError: 'str' object has no attribute 'keys' rules: - name: block-germany priority: 0 action: block: {} visibility_config: sampled_requests_enabled: yes cloud_watch_metrics_enabled: yes metric_name: block-germany statement: geo_match_statement: country_codes: - DE ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/module_utils/wafv2.py ADDITIONAL INFORMATION
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
) [PR #962/9230c698 backport][stable-2] wafv2_web_acl: prevent exception when element is not a dict This is a backport of PR #962 as merged into main (9230c69). SUMMARY the geo_match_statement statement paremeter country_codes is a list and will fail the current implementation File "/tmp/ansible_community.aws.wafv2_web_acl_payload_8xvwtxvw/ansible_community.aws.wafv2_web_acl_payload.zip/ansible_collections/community/aws/plugins/module_utils/wafv2.py", line 52, in wafv2_snake_dict_to_camel_dict AttributeError: 'str' object has no attribute 'keys' rules: - name: block-germany priority: 0 action: block: {} visibility_config: sampled_requests_enabled: yes cloud_watch_metrics_enabled: yes metric_name: block-germany statement: geo_match_statement: country_codes: - DE ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/module_utils/wafv2.py ADDITIONAL INFORMATION
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
the
geo_match_statementstatement paremetercountry_codesis a list and will fail the current implementationISSUE TYPE
COMPONENT NAME
plugins/module_utils/wafv2.py
ADDITIONAL INFORMATION