Hotfix for requests 2.32.0 compatibility #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
changed the title
ssbarnea
approved these changes
May 20, 2024
ssbarnea
added a commit
to ansible/molecule
that referenced
this pull request
May 20, 2024
|
The failures in CI groups 1, 2, 3 (these are for Docker Swarm, using Docker SDK for Python) and 6 (docker-compose v1, also using Docker SDK for Python) are to be expected. The late failures in CI group 4 are unfortunately also expected, since the docker_network tests (which generally don't use Docker SDK for Python) use Docker Swarm for one specific test (and for that it needs Docker SDK for Python). (If one of these groups doesn't fail, it's likely because they have an older requests version :) ) |
ssbarnea
added a commit
to ansible/molecule
that referenced
this pull request
May 20, 2024
Apparently requests==2.32.0 is incompatible with vendored versions of docker-py from inside community.docker collection. We do not have a direct dependency on that but one of our integration tests fails, so we only update our test dependencies. Related: docker/docker-py#3256 Related: ansible-collections/community.docker#860 Related: ansible-collections/community.docker#861
felixfontein
merged commit ab8b666
into
ansible-collections:main
94 of 129 checks passed
|
@ssbarnea thanks for reporting and reviewing this! |
rohinb2
added a commit
to run-house/runhouse
that referenced
this pull request
May 21, 2024
Bug that broke with latest requests release: ansible-collections/community.docker#861 docker/docker-py#3256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Requests 2.32.0 contains psf/requests@c0813a2, which breaks Docker SDK for Python, both the vendored code and the original. Requests no longer calls
HTTPAdapter.get_connection()fromHTTPAdapter.send(), but insteadHTTPAdapter._get_connection(). This breaks Docker SDK for Python, whose transports overwriteHTTPAdapter.get_connection()but notHTTPAdapter._get_connection().Fixes #860
Ref: docker/docker-py#3256
The parts of CI that use Docker SDK for Python will likely fail since it isn't fixed over there yet.
ISSUE TYPE
COMPONENT NAME
vendored Docker SDK for Python