-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix for requests 2.32.0 compatibility #861
Conversation
The failures in CI groups 1, 2, 3 (these are for Docker Swarm, using Docker SDK for Python) and 6 (docker-compose v1, also using Docker SDK for Python) are to be expected. The late failures in CI group 4 are unfortunately also expected, since the docker_network tests (which generally don't use Docker SDK for Python) use Docker Swarm for one specific test (and for that it needs Docker SDK for Python). (If one of these groups doesn't fail, it's likely because they have an older requests version :) ) |
Apparently requests==2.32.0 is incompatible with vendored versions of docker-py from inside community.docker collection. We do not have a direct dependency on that but one of our integration tests fails, so we only update our test dependencies. Related: docker/docker-py#3256 Related: ansible-collections/community.docker#860 Related: ansible-collections/community.docker#861
ab8b666
into
ansible-collections:main
@ssbarnea thanks for reporting and reviewing this! |
Bug that broke with latest requests release: ansible-collections/community.docker#861 docker/docker-py#3256
SUMMARY
Requests 2.32.0 contains psf/requests@c0813a2, which breaks Docker SDK for Python, both the vendored code and the original. Requests no longer calls
HTTPAdapter.get_connection()
fromHTTPAdapter.send()
, but insteadHTTPAdapter._get_connection()
. This breaks Docker SDK for Python, whose transports overwriteHTTPAdapter.get_connection()
but notHTTPAdapter._get_connection()
.Fixes #860
Ref: docker/docker-py#3256
The parts of CI that use Docker SDK for Python will likely fail since it isn't fixed over there yet.
ISSUE TYPE
COMPONENT NAME
vendored Docker SDK for Python