Remove ansible.posix dependency #1157
Conversation
…ible.posix dependency (except for testing).
felixfontein
force-pushed
the
drop-ansible.posix-dependency
branch
from
adbd72a to
f13d6f1
Compare
ansibullbot
added
affects_2.10
bug
|
I've also changed the shippable script to only install the requirements needed for every test type. This prevents collections to be installed for sanity checks which shoud only be needed during unit/integration tests. |
| @@ -0,0 +1,90 @@ | |||
| # This code is part of Ansible, but is an independent component. | |||
There was a problem hiding this comment.
How do we ensure that this file is kept in sync with ansible.posix? to prevent plugins/modules/system/aix_filesystem.py being exposed to a bug.
There was a problem hiding this comment.
A very good question. Maybe we could add an extra sanity test which compares whether the files are equal. Then we'll quickly find out when they update it. (Disadvantage: it will fail for every PR. But then it'll surface more quickly...)
There was a problem hiding this comment.
@gundalow @Andersson007 as a short-term solution, how about creating an issue for this, and maybe have a column in a project where issues tracking similar problems are tracked? (We could also use a label, but that doesn't work well cross-repository.)
Co-authored-by: John R Barker <john@johnrbarker.com>
|
Yes to using |
|
TODO:
(Also create and reference issues for other copies, like ipaddress in community.general and community.crypto.) |
|
@gundalow @Andersson007 thanks a lot for reviewing this! |
* Vendor plugins/module_utils/mount.py from ansible.posix, and drop ansible.posix dependency (except for testing). * Add ignore.txt entries. * Install test requirements conditionally. * Apply suggestions from code review Co-authored-by: John R Barker <john@johnrbarker.com> * Bump to major changes. Co-authored-by: John R Barker <john@johnrbarker.com> (cherry picked from commit 20f470c)
* Vendor plugins/module_utils/mount.py from ansible.posix, and drop ansible.posix dependency (except for testing). * Add ignore.txt entries. * Install test requirements conditionally. * Apply suggestions from code review Co-authored-by: John R Barker <john@johnrbarker.com> * Bump to major changes. Co-authored-by: John R Barker <john@johnrbarker.com> (cherry picked from commit 20f470c) Co-authored-by: Felix Fontein <felix@fontein.de>
SUMMARY
As mentioned here by vendoring the one file used by the
filesystemmodule.(Also part of #354.)
ISSUE TYPE
COMPONENT NAME
filesystem
collection