Remove redundant aliases from NIOS modules #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
affects_2.10
bug
|
The test The test |
|
Thanks for fixing some of the sanity issues! You need to remove the corresponding lines in the ignore-*.txt files (see the bot post above) to make the tests pass. Since this is a user-observable change, it should also have a changelog fragment. |
ansibullbot
added
tests
felixfontein
reviewed
Nov 3, 2020
felixfontein
reviewed
Nov 3, 2020
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
patchback bot
pushed a commit
that referenced
this pull request
Nov 4, 2020
* remove redundant alias * remove redundant aliases * remove redundant aliases * remove parameter-alias-self for nios_* * add fragment * Update changelogs/fragments/1223-nios-remove-redundant-aliases.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/net_tools/nios/nios_host_record.py Co-authored-by: Felix Fontein <felix@fontein.de> * remove parameter-alias-self for nios_host_record Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit b661c94)
|
@zjpeterson thanks a lot for fixing this! :) |
felixfontein
pushed a commit
that referenced
this pull request
Nov 4, 2020
* remove redundant alias * remove redundant aliases * remove redundant aliases * remove parameter-alias-self for nios_* * add fragment * Update changelogs/fragments/1223-nios-remove-redundant-aliases.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/net_tools/nios/nios_host_record.py Co-authored-by: Felix Fontein <felix@fontein.de> * remove parameter-alias-self for nios_host_record Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit b661c94) Co-authored-by: Zach Peterson <35381531+zjpeterson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #852.
Redundant aliases were present in the argument specs of these modules, causing unnecessary [WARNING] messages on execution.
ISSUE TYPE
COMPONENT NAME
nios_fixed_address
nios_host_record
nios_zone
ADDITIONAL INFORMATION
See #852