Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-1] Add information on docker module migration #1303

Merged
merged 2 commits into from
Nov 20, 2020
Merged

[stable-1] Add information on docker module migration #1303

merged 2 commits into from
Nov 20, 2020

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Documents the upcoming docker content removal for community.general 2.0.0.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

collection

@ansibullbot ansibullbot added WIP Work in progress affects_2.10 docs needs_triage owner_pr PR created by owner/maintainer labels Nov 14, 2020
@felixfontein felixfontein mentioned this pull request Nov 14, 2020
Closed
@felixfontein
Copy link
Collaborator Author

My idea is to merge this once community.docker 1.0.0 has been released and is included in ansible.in.

Let's polish this one so we can use it as a template for other content (community.routeros, community.postgresql, ...).

@felixfontein
Copy link
Collaborator Author

Note that this PR is for stable-1 directly, so this announcement will show up in the 1.3.0 changelog, but not in the 2.0.0 changelog.

@dmsimard dmsimard self-requested a review November 16, 2020 15:28
@felixfontein felixfontein mentioned this pull request Nov 17, 2020
Closed
@felixfontein felixfontein mentioned this pull request Nov 19, 2020
Closed
@gundalow gundalow changed the title [WIP] Add information on docker module migration [WIP] [stable-1] Add information on docker module migration Nov 20, 2020
gundalow
gundalow approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording and examples are great. Thank you.

dmsimard
dmsimard approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@dmsimard dmsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 87e31ae into ansible-collections:stable-1 Nov 20, 2020
@felixfontein felixfontein deleted the docker-announce-removal branch November 20, 2020 22:03
@felixfontein felixfontein changed the title [WIP] [stable-1] Add information on docker module migration [stable-1] Add information on docker module migration Nov 20, 2020
@felixfontein
Copy link
Collaborator Author

@acozine @gundalow @dmsimard thanks a lot for reviewing this!

This was referenced Nov 20, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsimard dmsimard dmsimard approved these changes

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
docs has_issue needs_triage owner_pr PR created by owner/maintainer WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixfontein @gundalow @dmsimard @ansibullbot