Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubevirt and set up redirects to community.kubevirt #1317

Merged
merged 4 commits into from
Jan 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/BOTMETA.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@ files:
$module_utils/ipa.py:
maintainers: $team_ipa
labels: ipa
$module_utils/kubevirt.py:
maintainers: $team_kubevirt
labels: cloud kubevirt
keywords: kubevirt
$module_utils/manageiq.py:
maintainers: $team_manageiq
labels: manageiq
Expand Down Expand Up @@ -171,9 +167,6 @@ files:
$modules/cloud/huawei/:
maintainers: $team_huawei huaweicloud
keywords: cloud huawei hwc
$modules/cloud/kubevirt/:
maintainers: $team_kubevirt kubevirt
keywords: kubevirt
$modules/cloud/linode/:
maintainers: $team_linode
$modules/cloud/linode/linode.py:
Expand Down Expand Up @@ -1008,7 +1001,6 @@ macros:
team_ipa: Akasurde Nosmoht fxfitz
team_jboss: Wolfant jairojunior wbrefvem
team_keycloak: eikef ndclt
team_kubevirt: machacekondra mmazur pkliczewski
team_linode: InTheCloudDan decentral1se displague rmcintosh
team_macos: Akasurde kyleabenson martinm82 danieljaouen indrajitr
team_manageiq: abellotti cben gtanzillo yaacov zgalor dkorn evertmulder
Expand Down
13 changes: 13 additions & 0 deletions changelogs/fragments/1317-kubevirt-migration-removal.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
removed_features:
- |
All Kubevirt modules and plugins have now been migrated from community.general to the `community.kubevirt <https://galaxy.ansible.com/community/kubevirt>`_ Ansible collection.
If you use ansible-base 2.10 or newer, redirections have been provided.
If you use Ansible 2.9 and installed this collection, you need to adjust the FQCNs (``community.general.kubevirt_vm`` → ``community.kubevirt.kubevirt_vm``) and make sure to install the community.kubevirt collection.
felixfontein marked this conversation as resolved.
Show resolved Hide resolved
breaking_changes:
- |
If you use Ansible 2.9 and the Kubevirt plugins or modules from this collection, community.general 2.0.0 results in errors when trying to use the Kubevirt content by FQCN, like ``community.general.kubevirt_vm``.
Since Ansible 2.9 is not able to use redirections, you will have to adjust your playbooks and roles manually to use the new FQCNs (``community.kubevirt.kubevirt_vm`` for the previous example) and to make sure that you have ``community.kubevirt`` installed.
If you use ansible-base 2.10 or newer and did not install Ansible 3.0.0, but installed (and/or upgraded) community.general manually, you need to make sure to also install the ``community.kubevirt`` collection if you are using any of the Kubevirt plugins or modules.
felixfontein marked this conversation as resolved.
Show resolved Hide resolved
While ansible-base 2.10 or newer can use the redirects that community.general 2.0.0 adds, the collection they point to (such as community.google) must be installed for them to work.
5 changes: 2 additions & 3 deletions galaxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@ authors:
description: null
license_file: COPYING
tags: [community]
# NOTE: No more dependencies can be added to this list
dependencies:
community.kubernetes: '>=1.0.0'
# NOTE: No dependencies are expected to be added here
# dependencies:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUCCESS

repository: https://github.com/ansible-collections/community.general
documentation: https://docs.ansible.com/ansible/latest/collections/community/general/
homepage: https://github.com/ansible-collections/community.general
Expand Down
27 changes: 20 additions & 7 deletions meta/runtime.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
---
requires_ansible: '>=2.9.10'
action_groups:
k8s:
- kubevirt_cdi_upload
- kubevirt_preset
- kubevirt_pvc
- kubevirt_rs
- kubevirt_template
- kubevirt_vm
ovirt:
- ovirt_affinity_label_facts
- ovirt_api_facts
Expand Down Expand Up @@ -218,6 +211,18 @@ plugin_routing:
tombstone:
removal_version: 2.0.0
warning_text: Use the modules from the theforeman.foreman collection instead.
kubevirt_cdi_upload:
redirect: community.kubevirt.kubevirt_cdi_upload
kubevirt_preset:
redirect: community.kubevirt.kubevirt_preset
kubevirt_pvc:
redirect: community.kubevirt.kubevirt_pvc
kubevirt_rs:
redirect: community.kubevirt.kubevirt_rs
kubevirt_template:
redirect: community.kubevirt.kubevirt_template
kubevirt_vm:
redirect: community.kubevirt.kubevirt_vm
ldap_attr:
deprecation:
removal_version: 3.0.0
Expand Down Expand Up @@ -553,6 +558,10 @@ plugin_routing:
redirect: community.docker.docker
hetzner:
redirect: community.hrobot.robot
kubevirt_common_options:
redirect: community.kubevirt.kubevirt_common_options
kubevirt_vm_options:
redirect: community.kubevirt.kubevirt_vm_options
postgresql:
redirect: community.postgresql.postgresql
module_utils:
Expand All @@ -568,6 +577,8 @@ plugin_routing:
redirect: community.google.gcp
hetzner:
redirect: community.hrobot.robot
kubevirt:
redirect: community.kubevirt.kubevirt
postgresql:
redirect: community.postgresql.postgresql
callback:
Expand All @@ -588,3 +599,5 @@ plugin_routing:
redirect: community.docker.docker_machine
docker_swarm:
redirect: community.docker.docker_swarm
kubevirt:
redirect: community.kubevirt.kubevirt
dmsimard marked this conversation as resolved.
Show resolved Hide resolved
133 changes: 0 additions & 133 deletions plugins/doc_fragments/kubevirt_common_options.py

This file was deleted.

103 changes: 0 additions & 103 deletions plugins/doc_fragments/kubevirt_vm_options.py

This file was deleted.

Loading