Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apache2 module: Add another shib module identifier #1383

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Apache2 module: Add another shib module identifier #1383

merged 2 commits into from
Nov 26, 2020

Conversation

peter-
Copy link
Contributor

@peter- peter- commented Nov 24, 2020

SUMMARY

Fixes #1379

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

apache2_module

@felixfontein felixfontein added backport-1 check-before-release PR will be looked at again shortly before release and merged if possible. labels Nov 25, 2020
@ansibullbot
Copy link
Collaborator

cc @berendt @n0trax @nerzhul @robinro
click here for bot help

@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug community_review module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review web_infrastructure labels Nov 26, 2020
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 26, 2020
@felixfontein felixfontein merged commit 382be57 into ansible-collections:main Nov 26, 2020
patchback bot pushed a commit that referenced this pull request Nov 26, 2020
@peter-
Apache2 module: Add another shib module identifier (#1383)
54f20bd 
* Add another shib module identifier to apache2 module (#1379)

* Update changelogs/fragments/1383-apache2-module-amend-shib-workaround.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 382be57)
@felixfontein
Copy link
Collaborator

@peter- thanks for fixing this!

@patchback patchback bot mentioned this pull request Nov 26, 2020
Merged
felixfontein pushed a commit that referenced this pull request Nov 26, 2020
@patchback @peter-
Apache2 module: Add another shib module identifier (#1383) (#1397)
bd8df8e 
* Add another shib module identifier to apache2 module (#1379)

* Update changelogs/fragments/1383-apache2-module-amend-shib-workaround.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 382be57)

Co-authored-by: peter <peter-@users.noreply.github.com>
@peter- peter- deleted the fix1379-apache2-module-amend-shib-workaround branch December 20, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review web_infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apache2 module workaround for Shibboleth needs updating
3 participants
@peter- @ansibullbot @felixfontein