Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1389/7f890c46 backport][stable-1] Tidy up validate-modules nonexistent-parameter-documented #1400

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Nov 26, 2020

This is a backport of PR #1389 as merged into main (7f890c4).

SUMMARY

Tidy up on sanity tests' ignore files, removing lines with validation-modules for these modules.

The focus was to pass the tests so no code was changed other than adjusting argument_spec for missing types or inconsistencies with the docs. The priority has been not to change any functionality, but to ensure that code and docs are synchronized.

Some lines were added back to the files, but a total of 17 lines were removed (among 2.9, 2.10 and 2.11).

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugins/modules/storage/zfs/zpool_facts.py
plugins/modules/storage/zfs/zfs_facts.py
plugins/modules/net_tools/nios/nios_host_record.py
plugins/modules/cloud/univention/udm_share.py
plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py

ADDITIONAL INFORMATION

* fixed validation-modules for plugins/modules/cloud/spotinst/spotinst_aws_elastigroup.py

* fixed validation-modules for plugins/modules/cloud/univention/udm_share.py

* fixed validation-modules for plugins/modules/net_tools/nios/nios_host_record.py

* fixed validation-modules for plugins/modules/storage/zfs/zfs_facts.py

* fixed validation-modules for plugins/modules/storage/zfs/zpool_facts.py

* Tidy up validate-modules ignores nonexistent-parameter-documented

* Adjustments per the PR

* Removed no longer needed ignore line for udm_share.py

(cherry picked from commit 7f890c4)
@keachi
Copy link

keachi commented Nov 26, 2020

udm_share lgtm

@felixfontein felixfontein merged commit ab94b0a into stable-1 Nov 26, 2020
@felixfontein felixfontein deleted the patchback/backports/stable-1/7f890c46456512a1715d1b967ba58f4c71b2fd8f/pr-1389 branch November 26, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud community_review docs module module net_tools new_contributor Help guide this first time contributor plugins plugin (any type) storage tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants