Tidy up validate-modules ignores for modules: net_tools/nios #1598
Conversation
- ``http_pool_connections`` - ``http_pool_maxsize`` - ``silent_ssl_warnings``
ansibullbot
added
affects_2.10
community_review
docs
docs_fragments
|
The test The test |
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
|
I was looking forward to hear from the module maintainers on this one. |
|
@russoz I have some doubts that there are active maintainers. Also, in theory, these modules should be removed here eventually and be replaced with the ones in https://github.com/infobloxopen/infoblox-ansible, but right now I'm not sure when that will happen. It does not look like anything will happen in the next weeks, i.e. it won't happen for Ansible 3.0.0 / community.general 2.0.0. |
|
@felixfontein in that case, given #1598 (comment) and given the fact these modules are passing both unit and integration tests, may we merge this PR? BTW, I wouldn't mind creating another PR to add the deprecations - for 3.0.0? - to these guys. They would go along with the clous/ovirt ones. |
|
@russoz we do not have integration tests for the NIOS modules that run in CI. That's why I'm hesistant of merging this. About deprecating these: we should not deprecate them. We keep them until that other collection is included in Ansible (whenever that happens), and then remove the modules in the next major version (and add redirects). |
Co-authored-by: Felix Fontein <felix@fontein.de>
|
The tests should no longer fail thanks to #1615. |
|
@russoz thanks a lot for improving the nios modules, and reducing sanity ignores! :) |
SUMMARY
Tidy up on sanity tests' ignore files, removing lines with validation-modules for these modules.
The focus was to pass the tests so no code was changed other than adjusting argument_spec for missing types or inconsistencies with the docs. The priority has been not to change any functionality, but to ensure that code and docs are synchronized.
A total of 238 lines were removed (among 2.9, 2.10 and 2.11).
ISSUE TYPE
COMPONENT NAME
plugins/modules/net_tools/nios/nios_nsgroup.py
plugins/modules/net_tools/nios/nios_zone.py
plugins/modules/net_tools/nios/nios_txt_record.py
plugins/modules/net_tools/nios/nios_srv_record.py
plugins/modules/net_tools/nios/nios_ptr_record.py
plugins/modules/net_tools/nios/nios_network_view.py
plugins/modules/net_tools/nios/nios_network.py
plugins/modules/net_tools/nios/nios_naptr_record.py
plugins/modules/net_tools/nios/nios_mx_record.py
plugins/modules/net_tools/nios/nios_member.py
plugins/modules/net_tools/nios/nios_host_record.py
plugins/modules/net_tools/nios/nios_fixed_address.py
plugins/modules/net_tools/nios/nios_dns_view.py
plugins/modules/net_tools/nios/nios_cname_record.py
plugins/modules/net_tools/nios/nios_aaaa_record.py
plugins/modules/net_tools/nios/nios_a_record.py
ADDITIONAL INFORMATION
There was a bit of coding there, so the boundary between docs and bugfix PR is a little fuzzy. Please let me know if a bugfix changelog should be added.