Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-remove wrongly removed ovirt modules and adjust deprecation to Ansible 2.14 #353

Merged
merged 4 commits into from
May 18, 2020

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fix wrong removal from ansible/ansible#67826.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt
ovirt_affinity_label_facts
ovirt_api_facts
ovirt_cluster_facts
ovirt_datacenter_facts
ovirt_disk_facts
ovirt_event_facts
ovirt_external_provider_facts
ovirt_group_facts
ovirt_host_facts
ovirt_host_storage_facts
ovirt_network_facts
ovirt_nic_facts
ovirt_permission_facts
ovirt_quota_facts
ovirt_scheduling_policy_facts
ovirt_snapshot_facts
ovirt_storage_domain_facts
ovirt_storage_template_facts
ovirt_storage_vm_facts
ovirt_tag_facts
ovirt_template_facts
ovirt_user_facts
ovirt_vm_facts
ovirt_vmpool_facts

…ible 2.14 (regular 4 version deprecation cycle).
@felixfontein felixfontein requested a review from gundalow May 16, 2020 19:27
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug module module labels May 16, 2020
@ansibullbot ansibullbot added the tests tests label May 16, 2020
@ansibullbot
Copy link
Collaborator

@felixfontein felixfontein requested a review from Andersson007 May 18, 2020 17:34
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gundalow gundalow merged commit a0a5345 into ansible-collections:master May 18, 2020
@felixfontein felixfontein deleted the un-remove-ovirt branch May 18, 2020 19:46
@felixfontein
Copy link
Collaborator Author

@gundalow thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug has_issue module module new_plugin New plugin tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants