Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxmox local connection support. #4027

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Proxmox local connection support. #4027

wants to merge 4 commits into from
+55 −45

Conversation

reitermarkus
Copy link
Contributor

@reitermarkus reitermarkus commented Jan 12, 2022 •
edited
Loading

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

proxmox, proxmox_kvm, etc.

ADDITIONAL INFORMATION

Use the local backend when no credential parameters are specified in order to use SSH instead of the HTTP API.

--

Closes #5449.

@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Kogelvis @Thulium-Drake @UnderGreen @helldorado @joshainglis @karmab @paginabianca @tleguern
click here for bot help

@ansibullbot ansibullbot added cloud docs_fragments docs_fragments plugin (shared docs) feature This issue/PR relates to a feature request module module module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type) labels Jan 12, 2022
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Jan 12, 2022
felixfontein
felixfontein reviewed Jan 12, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thakns for your contribution! Please add a changelog fragment.

I would suggest to split this up into (at least) two PRs: one for the new feature, and one for refactoring. The way this PR is now makes it really hard to review, since there are so many changes at once.

plugins/doc_fragments/proxmox.py Outdated Show resolved Hide resolved
plugins/doc_fragments/proxmox.py Outdated Show resolved Hide resolved
@felixfontein felixfontein added backport-4 check-before-release PR will be looked at again shortly before release and merged if possible. labels Jan 12, 2022
@reitermarkus reitermarkus force-pushed the proxmox-openssh branch 2 times, most recently from 49cd0aa to 19859e0 Compare January 12, 2022 08:40
This was referenced Jan 12, 2022
Merged
Merged
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI tests tests unit tests/unit and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Jan 12, 2022
@ansibullbot

This comment has been minimized.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 12, 2022
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Jan 15, 2022
@ansibullbot ansibullbot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label May 26, 2023
@ansibullbot
Copy link
Collaborator

@reitermarkus This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

@reitermarkus
Copy link
Contributor Author

Still waiting for a fix upstream. According to https://bugzilla.proxmox.com/show_bug.cgi?id=4333#c5, my proposed patch was merged and then reverted again.

@ansibullbot ansibullbot removed the needs_info This issue requires further information. Please answer any outstanding questions label Jun 11, 2023
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI and removed stale_ci CI is older than 7 days, rerun before merging labels Dec 20, 2023
@felixfontein
Copy link
Collaborator

CC @krauthosting

@krauthosting krauthosting mentioned this pull request Feb 9, 2024
Closed
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Sep 28, 2024
@reitermarkus reitermarkus force-pushed the proxmox-openssh branch 2 times, most recently from 99cf835 to a3bf6c6 Compare September 28, 2024 22:57
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot
Copy link
Collaborator

cc @jwbernin
click here for bot help

@ansibullbot ansibullbot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Sep 28, 2024
@reitermarkus
Default to local Proxmoxer backend.
9c2be80 
# Conflicts:
#	plugins/module_utils/proxmox.py
#	plugins/modules/proxmox.py
#	plugins/modules/proxmox_tasks_info.py
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Sep 29, 2024
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Sep 29, 2024
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Oct 7, 2024
@ansibullbot ansibullbot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
check-before-release PR will be looked at again shortly before release and merged if possible. cloud docs_fragments docs_fragments plugin (shared docs) feature This issue/PR relates to a feature request has_issue module_utils module_utils module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging tests tests unit tests/unit WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support proxmoxer local mode
4 participants
@reitermarkus @ansibullbot @ls-initiatives @felixfontein