Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #7143/07a47c04 backport][stable-8] add template option to proxmox and proxmox_kvm #7488

Merged
merged 1 commit into from
Nov 13, 2023
Merged

[PR #7143/07a47c04 backport][stable-8] add template option to proxmox and proxmox_kvm #7488

merged 1 commit into from
Nov 13, 2023

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Nov 5, 2023

This is a backport of PR #7143 as merged into main (07a47c0).

SUMMARY

Adds an option for converting LXC containers and KVM VMs to templates with the proxmox and proxmox_kvm modules.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

proxmox and proxmox_kvm

ADDITIONAL INFORMATION

@etrombly @patchback
add template option to proxmox and proxmox_kvm (#7143)
0f7c2e6 
* add template option to proxmox and proxmox_kvm

* make recommended updates

* fix tests

* resolve comments on PR

* save changes to changelog fragment

* Update changelogs/fragments/7143-proxmox-template.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Eric Trombly <etrombly@iomaxis.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 07a47c0)
@patchback patchback bot mentioned this pull request Nov 5, 2023
Merged
@felixfontein felixfontein marked this pull request as draft November 5, 2023 14:57
@felixfontein
Copy link
Collaborator

Marking as draft so this won't get merged until the last 8.0.x bugfix release is out.

@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @UnderGreen @helldorado @joshainglis @karmab
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress backport feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Nov 5, 2023
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Nov 13, 2023
@felixfontein felixfontein marked this pull request as ready for review November 13, 2023 19:21
@felixfontein felixfontein merged commit 79cfc48 into stable-8 Nov 13, 2023
117 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-8/07a47c047bc41e173b2218229c76ec121dbc26ca/pr-7143 branch November 13, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @ansibullbot @etrombly