Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module git config info #7587

Merged
merged 1 commit into from
Nov 29, 2023
Merged

New module git config info #7587

merged 1 commit into from
Nov 29, 2023

Conversation

guenhter
Copy link
Contributor

SUMMARY

Based on this discussion #7260 (comment)
this new module for only reading out git configs is now created.

ISSUE TYPE
  • New Module/Plugin Pull Request
COMPONENT NAME

git_config_info

ADDITIONAL INFORMATION

The new module is only here to read out git configs and deprecate those functionalities in the git_config module

@ansibullbot
Copy link
Collaborator

cc @djmattyg007 @mgedmin
click here for bot help

@ansibullbot ansibullbot added integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Nov 24, 2023
@guenhter guenhter mentioned this pull request Nov 24, 2023
Merged
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 24, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch labels Nov 24, 2023
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 24, 2023
felixfontein
felixfontein reviewed Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

changelogs/fragments/7551-new-git-config-info-module.yml Outdated Show resolved Hide resolved
plugins/modules/git_config.py Outdated Show resolved Hide resolved
plugins/modules/git_config_info.py Outdated Show resolved Hide resolved
plugins/modules/git_config_info.py Outdated Show resolved Hide resolved
plugins/modules/git_config_info.py Outdated Show resolved Hide resolved
plugins/modules/git_config_info.py Outdated Show resolved Hide resolved
plugins/modules/git_config_info.py Outdated Show resolved Hide resolved
plugins/modules/git_config_info.py Show resolved Hide resolved
plugins/modules/git_config_info.py Outdated Show resolved Hide resolved
plugins/modules/git_config_info.py Show resolved Hide resolved
felixfontein
felixfontein reviewed Nov 26, 2023
View reviewed changes
plugins/modules/git_config_info.py Outdated Show resolved Hide resolved
plugins/modules/git_config_info.py Outdated Show resolved Hide resolved
felixfontein
felixfontein approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If nobody objects, I'll merge this in a few days.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 29, 2023
@felixfontein felixfontein merged commit 1b9d437 into ansible-collections:main Nov 29, 2023
124 checks passed
@patchback Patchback
Copy link

patchback bot commented Nov 29, 2023 •
edited
Loading

Backport to stable-8: cherry-pick succeeded

Backport PR branch: patchback/backports/stable-8/1b9d437be8d085b714f2c38208b30401e7dcf2d9/pr-7587

PR branch created, proceeding with making a PR.

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 29, 2023
@guenhter @patchback
New module git config info (#7587)
ef37fcb 
Add new module git_config_info

(cherry picked from commit 1b9d437)
@felixfontein
Copy link
Collaborator

@guenhter thanks for your contribution!

@felixfontein felixfontein added backport-8 Automatically create a backport for the stable-8 branch and removed backport-8 Automatically create a backport for the stable-8 branch labels Nov 29, 2023
@patchback Patchback
Copy link

patchback bot commented Nov 29, 2023 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/1b9d437be8d085b714f2c38208b30401e7dcf2d9/pr-7587

Backported as #7638

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 29, 2023
@guenhter @patchback
New module git config info (#7587)
8cd7c8f 
Add new module git_config_info

(cherry picked from commit 1b9d437)
@patchback patchback bot mentioned this pull request Nov 29, 2023
Merged
@guenhter guenhter deleted the new-module-git_config_info branch November 29, 2023 08:22
felixfontein pushed a commit that referenced this pull request Nov 29, 2023
@patchback @guenhter
[PR #7587/1b9d437b backport][stable-8] New module git config info (#7638
ee7ba1a 
)

New module git config info (#7587)

Add new module git_config_info

(cherry picked from commit 1b9d437)

Co-authored-by: Günther Grill <guenhter@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guenhter @ansibullbot @felixfontein