Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #7600 add hookscript parameter to proxmox_kvm #7602

Merged
merged 5 commits into from
Dec 1, 2023
Merged

fix #7600 add hookscript parameter to proxmox_kvm #7602

merged 5 commits into from
Dec 1, 2023

Conversation

elelay
Copy link
Contributor

@elelay elelay commented Nov 26, 2023

SUMMARY

Fixes #7600 add hookscript parameter to proxmox_kvm module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

proxmox_kvm

ADDITIONAL INFORMATION

The parameter was present in PROXMOX VE as early as April 2019.
It had been added to the proxmox.py module in #245 on May 18, 2020 but not to proxmox_kvm.py.
This PR adds it.

@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @UnderGreen @helldorado @joshainglis @karmab
click here for bot help

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI feature This issue/PR relates to a feature request module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) labels Nov 26, 2023
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 26, 2023
felixfontein
felixfontein reviewed Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

changelogs/fragments/7600-proxmox_kvm-hookscript.yml Outdated Show resolved Hide resolved
plugins/modules/proxmox_kvm.py Show resolved Hide resolved
@felixfontein
Copy link
Collaborator

felixfontein commented Nov 26, 2023 •
edited
Loading

This needs to be updated when #7540 is merged first, and vice versa.

Sorry, that was too quick. But: does the update code also need to know about this new option?

elelay and others added 2 commits November 26, 2023 17:37
@elelay @felixfontein
add missing version_added
ae351e8 
Co-authored-by: Felix Fontein <felix@fontein.de>
@elelay @felixfontein
changelog: add missing dot
73a3172 
Co-authored-by: Felix Fontein <felix@fontein.de>
@elelay
Copy link
Contributor Author

elelay commented Nov 26, 2023

does the update code also need to know about this new option?

I've tested the update and delete modes: at least they work on PVE 8.1. Not sure about a previous version.

@felixfontein
Copy link
Collaborator

From the code this new option shouldn't have an impact on existing tasks (that don't use the option), so even if update doesn't work for this new option for some versions, it won't break any existing user of the module (unless they start using this option). So let's see whether someone complains that it doesn't work :)

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch labels Nov 26, 2023
@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this at the end of the upcoming week (~around Friday).

@elelay
Copy link
Contributor Author

elelay commented Nov 26, 2023

Thanks for the welcoming and positive feedback!

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 1, 2023
@felixfontein felixfontein merged commit e3a3950 into ansible-collections:main Dec 1, 2023
124 checks passed
@patchback Patchback
Copy link

patchback bot commented Dec 1, 2023 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/e3a3950e3db9d3954490218bf68f6a98259b81fc/pr-7602

Backported as #7649

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@elelay thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Dec 1, 2023
@elelay @patchback
fix #7600 add hookscript parameter to proxmox_kvm (#7602)
a32dcab 
* fix #7600 add hookscript parameter to proxmox_kvm

* add issue url to changelog

* fix changelog missing quote

* add missing version_added

Co-authored-by: Felix Fontein <felix@fontein.de>

* changelog: add missing dot

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit e3a3950)
@patchback patchback bot mentioned this pull request Dec 1, 2023
Merged
felixfontein pushed a commit that referenced this pull request Dec 1, 2023
@patchback @elelay
[PR #7602/e3a3950e backport][stable-8] fix #7600 add hookscript param…
2c6b2e3 
…eter to proxmox_kvm (#7649)

fix #7600 add hookscript parameter to proxmox_kvm (#7602)

* fix #7600 add hookscript parameter to proxmox_kvm

* add issue url to changelog

* fix changelog missing quote

* add missing version_added

Co-authored-by: Felix Fontein <felix@fontein.de>

* changelog: add missing dot

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit e3a3950)

Co-authored-by: Eric Le Lay <222469+elelay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add hookscript parameter to proxmox_kvm
3 participants
@elelay @ansibullbot @felixfontein