Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docstrings #226

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Conversation

briantist
Copy link
Collaborator

SUMMARY

Addresses the plugin validation changes merged in devel:

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docsrings

@briantist briantist added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request tests Adds or modifies tests labels Mar 4, 2022
@briantist briantist self-assigned this Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #226 (2db85ea) into main (40eeaa5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files          51       51           
  Lines        2206     2206           
  Branches      168      168           
=======================================
  Hits         2143     2143           
  Misses         49       49           
  Partials       14       14           
Flag Coverage Δ
env_docker-default 97.14% <ø> (ø)
integration 81.07% <ø> (ø)
sanity 38.37% <ø> (ø)
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_aws_iam 50.00% <ø> (ø)
target_auth_cert 86.36% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_ldap 89.47% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_auth_userpass 85.71% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 73.28% <ø> (ø)
target_filter_vault_login_token 77.77% <ø> (ø)
target_import 38.37% <ø> (ø)
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_login 100.00% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_lookup_vault_token_create 82.97% <ø> (ø)
target_module_utils 96.72% <ø> (ø)
target_module_vault_login 93.93% <ø> (ø)
target_module_vault_pki_generate_certificate 78.26% <ø> (ø)
target_module_vault_read 92.10% <ø> (ø)
target_module_vault_token_create 90.00% <ø> (ø)
target_modules 64.16% <ø> (ø)
units 92.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/lookup/hashi_vault.py 84.00% <ø> (ø)
plugins/lookup/vault_login.py 100.00% <ø> (ø)
plugins/lookup/vault_read.py 95.00% <ø> (ø)
plugins/lookup/vault_token_create.py 95.74% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40eeaa5...2db85ea. Read the comment docs.

@briantist briantist merged commit 9604e74 into ansible-collections:main Mar 4, 2022
@briantist briantist deleted the plugin_validation branch March 4, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request tests Adds or modifies tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants