Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Helm should include appVersion in it's idempotence check #246

Closed
nat45928 opened this issue Oct 2, 2020 · 0 comments · Fixed by #247
Closed

Helm should include appVersion in it's idempotence check #246

nat45928 opened this issue Oct 2, 2020 · 0 comments · Fixed by #247
Labels
has_pr This issue has a related PR that may close it. priority/medium type/bug Something isn't working
Milestone

Comments

@nat45928
Copy link
Contributor

nat45928 commented Oct 2, 2020

SUMMARY

When re-deploying a Helm chart using Ansible I noticed no deployment was preformed and the console output listed my task as ok instead of changed. It appears that the Helm module only uses the chart key to determine if a Chart needs to be upgraded during execution, see here. This check should consider the appVersion specification of the chart as well.

I saw a few other related issues looking to implemented helm-diff as well which be a more complete solution.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

community.kubernetes.helm

ANSIBLE VERSION
ansible 2.9.12
  config file = None
  configured module search path = ['/<path>/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /<path>/.venv/lib/python3.8/site-packages/ansible
  executable location = /<path>/.venv/bin/ansible
  python version = 3.8.2 (default, Jul 16 2020, 14:00:26) [GCC 9.3.0]
CONFIGURATION
OS / ENVIRONMENT
STEPS TO REPRODUCE

Modify a chart's appVersion and re-run the Helm task. Observe the Helm chart is not updated even though the Chart specification has changed.

EXPECTED RESULTS

Charts that change the appVersion key should be re-deployed.

ACTUAL RESULTS

The deployed release remains unchanged.

nat45928 added a commit to nat45928/community.kubernetes that referenced this issue Oct 2, 2020
When upgrading a Helm release include the chart's appVersion in
the idempotence check.

Fixes ansible-collections#246
@tima tima added this to the 1.1.0 milestone Oct 3, 2020
@tima tima added has_pr This issue has a related PR that may close it. priority/medium type/bug Something isn't working labels Oct 3, 2020
nat45928 added a commit to nat45928/community.kubernetes that referenced this issue Oct 5, 2020
When upgrading a Helm release include the chart's appVersion in the idempotence check.

Fixes ansible-collections#246
nat45928 added a commit to nat45928/community.kubernetes that referenced this issue Oct 5, 2020
When upgrading a Helm release include the chart's appVersion in the idempotence check.

Fixes ansible-collections#246
nat45928 added a commit to nat45928/community.kubernetes that referenced this issue Oct 5, 2020
When upgrading a Helm release include the chart's appVersion in the idempotence check.

Fixes ansible-collections#246
nat45928 added a commit to nat45928/community.kubernetes that referenced this issue Oct 6, 2020
When upgrading a Helm release include the chart's appVersion in the idempotence check.

Fixes ansible-collections#246
@tima tima closed this as completed in #247 Oct 7, 2020
tima pushed a commit that referenced this issue Oct 7, 2020
When upgrading a Helm release include the chart's appVersion in the idempotence check. Fixes #246
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has_pr This issue has a related PR that may close it. priority/medium type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants