Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

helm_plugin requires release_namespace #357

Closed
ecksun opened this issue Jan 28, 2021 · 3 comments
Closed

helm_plugin requires release_namespace #357

ecksun opened this issue Jan 28, 2021 · 3 comments
Assignees
Labels
has_pr This issue has a related PR that may close it. type/enhancement New feature or request verified The issue is reproduced

Comments

@ecksun
Copy link

ecksun commented Jan 28, 2021

SUMMARY

release_namespace is required in the helm_plugin task.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

community.kubernetes.helm_plugin

ANSIBLE VERSION
ansible 2.10.3
  config file = /home/user/code/noomi/devops/ansible/cloud-infrastructure/ansible.cfg
  configured module search path = ['/home/user/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/user/code/noomi/devops/ansible/.venv/lib/python3.7/site-packages/ansible
  executable location = /home/user/code/noomi/devops/ansible/.venv/bin/ansible
  python version = 3.7.3 (default, Jul 25 2020, 13:03:44) [GCC 8.3.0]
CONFIGURATION
INTERPRETER_PYTHON(/home/user/code/noomi/devops/ansible/cloud-infrastructure/ansible.cfg) = ../.venv/bin/python3
OS / ENVIRONMENT
STEPS TO REPRODUCE
- name: Install local Helm plugin for Google Cloud Storage repository support
  community.kubernetes.helm_plugin:
    plugin_path: https://github.com/hayorov/helm-gcs
    state: present

Looking at the souce this seems to affect even master.

I'm assuming that in many cases it make sense to have the argument required (perhaps it was more relevant with helm2?), but I don't think it does in this case.

EXPECTED RESULTS

The task should run without having to specify namespace, as the plugin is only local and doesn't deal with any namespaces.

ACTUAL RESULTS
TASK [therole : Install local Helm plugin for Google Cloud Storage repository support] ********************************************************************************************************************************************************************************************************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "missing required arguments: release_namespace"}
@Akasurde
Copy link
Member

@ecksun Thanks for reporting this. Do you think we should make this as an optional parameter?

@Akasurde Akasurde added type/enhancement New feature or request verified The issue is reproduced labels Jan 29, 2021
@ecksun
Copy link
Author

ecksun commented Jan 29, 2021

@ecksun Thanks for reporting this. Do you think we should make this as an optional parameter?

probably?

I'm not super familiar with helm and helm plugins so there might be something I haven't understood correctly or that I have missed. But consider my current task:

- name: Install local Helm plugin for Google Cloud Storage repository support
  community.kubernetes.helm_plugin:
    plugin_path: https://github.com/hayorov/helm-gcs
    release_namespace: NOT_REALLY_REQUIRED
    state: present

Akasurde added a commit to Akasurde/community.kubernetes that referenced this issue Feb 2, 2021
* removed release_namespace from helm_plugin
* removed release_namespace from helm_plugin_info

Fixes: ansible-collections#357

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde
Copy link
Member

Akasurde commented Feb 2, 2021

resolved_by_pr #358

@Akasurde Akasurde self-assigned this Feb 2, 2021
@Akasurde Akasurde added the has_pr This issue has a related PR that may close it. label Feb 2, 2021
Akasurde added a commit to Akasurde/community.kubernetes that referenced this issue Feb 2, 2021
* removed release_namespace from helm_plugin
* removed release_namespace from helm_plugin_info

Fixes: ansible-collections#357

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Akasurde added a commit to Akasurde/community.kubernetes that referenced this issue Feb 2, 2021
Modules modified -
* helm_plugin
* helm_plugin_info

Fixes: ansible-collections#357

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has_pr This issue has a related PR that may close it. type/enhancement New feature or request verified The issue is reproduced
Projects
None yet
Development

No branches or pull requests

2 participants