Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Use improved kubernetes diffs where possible #105

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

willthames
Copy link
Collaborator

SUMMARY

Use information from strategic merges to improve
the quality of diffs, particularly for list items
(order no longer important, and adding/removing an
item from a list just shows that item in the diff,
not the whole list)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

common

ADDITIONAL INFORMATION

@willthames
Copy link
Collaborator Author

For this to be useful, openshift/openshift-restclient-python#366 needs to be merged and released, but this will behave no differently to currently until that time

@willthames willthames requested a review from fabianvf May 27, 2020 08:09
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #105 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   42.88%   43.19%   +0.31%     
==========================================
  Files           3        3              
  Lines         541      544       +3     
  Branches      110      110              
==========================================
+ Hits          232      235       +3     
  Misses        266      266              
  Partials       43       43              
Impacted Files Coverage Δ
...ommunity/kubernetes/plugins/module_utils/common.py 38.83% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18dfb68...4b7db6f. Read the comment docs.

Use information from strategic merges to improve
the quality of diffs, particularly for list items
(order no longer important, and adding/removing an
item from a list just shows that item in the diff,
not the whole list)
@fabianvf fabianvf merged commit cdeab63 into ansible-collections:master Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants