Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Flake8 #123

Merged
merged 5 commits into from
Jun 15, 2020
Merged

Flake8 #123

merged 5 commits into from
Jun 15, 2020

Conversation

willthames
Copy link
Collaborator

SUMMARY

Turn on flake8 checks

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

flake8 checks are always good to do

I've gone for the max-line-length that the project currently meets but I'd be keen to drive it down nearer to 120 (based on community agreement)

@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #123 into master will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   42.88%   42.53%   -0.35%     
==========================================
  Files           3        3              
  Lines         541      536       -5     
  Branches      110      110              
==========================================
- Hits          232      228       -4     
+ Misses        266      265       -1     
  Partials       43       43              
Impacted Files Coverage Δ
...s/community/kubernetes/plugins/module_utils/raw.py 43.96% <0.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18dfb68...61c3372. Read the comment docs.

Copy link
Collaborator

@geerlingguy geerlingguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Keeps the code even more squeaky-clean.

@geerlingguy geerlingguy merged commit 0e92889 into ansible-collections:master Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants